Closed Bug 1391478 Opened 4 years ago Closed 4 years ago

Pseudo-elements container toggles should work with a click event

Categories

(DevTools :: Inspector: Rules, enhancement, P3)

enhancement

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: gl, Assigned: gl)

Details

Attachments

(1 file)

The Pseudo-elements container toggle requires a dblclick on the header to expand/collapse. This should be a click event to follow the accordion behavior that we have. In doing this, we can also remove the twisty event handler.

STR.
1. Go to about:home
2. Open Inspector
3. Select Node a#aboutMozilla
4. See Pseudo-elements container in the Rules
5. Double click to expand/collapse.
6. Feel sad.
Attached patch 1391478.patchSplinter Review
Attachment #8898541 - Flags: review?(bgrinstead)
Comment on attachment 8898541 [details] [diff] [review]
1391478.patch

Review of attachment 8898541 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me with a green try
Attachment #8898541 - Flags: review?(bgrinstead) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2900b2b1b20a
Pseudo-elements containner toggle should work with a click event instead of dblclick. r=bgrins
Backed out bug 1391487 and bug 1391478 for failing devtools' browser_inspector_highlighter-comments.js:

https://hg.mozilla.org/integration/mozilla-inbound/rev/6da32050f282bbd31bacfaa6897b2fbc5bc5e4fb
https://hg.mozilla.org/integration/mozilla-inbound/rev/023bb3482e57f4f0be17ed23c3ae3daedee47cf2

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=f4b8bd3d68c8f7b14e7c38f45c1c482f349ad704&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=124245229&repo=mozilla-inbound

[task 2017-08-18T21:41:23.689396Z] 21:41:23     INFO - Getting the markup-container for node #id4
[task 2017-08-18T21:41:23.693469Z] 21:41:23     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_highlighter-comments.js | Found markup-container for selector: #id4 - 
[task 2017-08-18T21:41:23.694421Z] 21:41:23     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_highlighter-comments.js | Highlighter is hidden - 
[task 2017-08-18T21:41:23.695741Z] 21:41:23     INFO - Hovering over a text node and waiting for highlighter to appear.
[task 2017-08-18T21:41:23.696544Z] 21:41:23     INFO - Hovering the text node "Visible text node" in the markup view
[task 2017-08-18T21:41:23.697699Z] 21:41:23     INFO - Buffered messages finished
[task 2017-08-18T21:41:23.699920Z] 21:41:23     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/test/browser_inspector_highlighter-comments.js | Test timed out - 
[task 2017-08-18T21:41:23.700994Z] 21:41:23     INFO - Removing tab.
[task 2017-08-18T21:41:23.701864Z] 21:41:23     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2017-08-18T21:41:23.703181Z] 21:41:23     INFO - Got event: 'TabClose' on [object XULElement].
[task 2017-08-18T21:41:23.704130Z] 21:41:23     INFO - Tab removed and finished closing
Flags: needinfo?(gl)
Flags: needinfo?(gl)
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef38fd38b435
Pseudo-elements container toggle should work with a click event instead of dblclick. r=bgrins
https://hg.mozilla.org/mozilla-central/rev/ef38fd38b435
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.