DevTools toolbar should match the size of the Photon compact toolbar

RESOLVED FIXED in Firefox 57

Status

()

Firefox
Developer Tools
P3
normal
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: gl, Assigned: gl)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

4 months ago
DevTools toolbar should match the size of the Photon compact toolbar. (29px tall)

http://searchfox.org/mozilla-central/source/browser/themes/shared/tabs.inc.css#16
(Assignee)

Updated

4 months ago
Blocks: 1389730
(Assignee)

Comment 1

4 months ago
Created attachment 8898658 [details] [diff] [review]
1391487.patch
Attachment #8898658 - Flags: review?(bgrinstead)
Attachment #8898658 - Flags: review?(bgrinstead) → review+

Comment 2

4 months ago
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4b8bd3d68c8
DevTools toolbar should match the size of the Photon compact toolbar. r=bgrins
Backed out bug 1391487 and bug 1391478 for failing devtools' browser_inspector_highlighter-comments.js:

https://hg.mozilla.org/integration/mozilla-inbound/rev/6da32050f282bbd31bacfaa6897b2fbc5bc5e4fb
https://hg.mozilla.org/integration/mozilla-inbound/rev/023bb3482e57f4f0be17ed23c3ae3daedee47cf2

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=f4b8bd3d68c8f7b14e7c38f45c1c482f349ad704&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=124245229&repo=mozilla-inbound

[task 2017-08-18T21:41:23.689396Z] 21:41:23     INFO - Getting the markup-container for node #id4
[task 2017-08-18T21:41:23.693469Z] 21:41:23     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_highlighter-comments.js | Found markup-container for selector: #id4 - 
[task 2017-08-18T21:41:23.694421Z] 21:41:23     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_highlighter-comments.js | Highlighter is hidden - 
[task 2017-08-18T21:41:23.695741Z] 21:41:23     INFO - Hovering over a text node and waiting for highlighter to appear.
[task 2017-08-18T21:41:23.696544Z] 21:41:23     INFO - Hovering the text node "Visible text node" in the markup view
[task 2017-08-18T21:41:23.697699Z] 21:41:23     INFO - Buffered messages finished
[task 2017-08-18T21:41:23.699920Z] 21:41:23     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/test/browser_inspector_highlighter-comments.js | Test timed out - 
[task 2017-08-18T21:41:23.700994Z] 21:41:23     INFO - Removing tab.
[task 2017-08-18T21:41:23.701864Z] 21:41:23     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2017-08-18T21:41:23.703181Z] 21:41:23     INFO - Got event: 'TabClose' on [object XULElement].
[task 2017-08-18T21:41:23.704130Z] 21:41:23     INFO - Tab removed and finished closing
Flags: needinfo?(gl)
(Assignee)

Updated

4 months ago
Flags: needinfo?(gl)
(Assignee)

Comment 4

3 months ago
Created attachment 8902385 [details] [diff] [review]
1391487.patch [2.0]
Attachment #8898658 - Attachment is obsolete: true
Attachment #8902385 - Flags: review+
(Assignee)

Comment 5

3 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3041184cdc794b6f87aa4f296042d68e6d4f3ead
(Assignee)

Comment 6

3 months ago
Created attachment 8902390 [details] [diff] [review]
1391487.patch [3.0]
Attachment #8902385 - Attachment is obsolete: true
Attachment #8902390 - Flags: review+
(Assignee)

Comment 7

3 months ago
Comment on attachment 8902390 [details] [diff] [review]
1391487.patch [3.0]

Added * { box-sizing: border-box } for the toolbox. We want this toolbar to be 29px including the border. 

I think we are getting an intermittent in the test with this bigger toolbar because the Visible text node isn't visible in the markup view.
Attachment #8902390 - Flags: review+ → review?(bgrinstead)
Comment on attachment 8902390 [details] [diff] [review]
1391487.patch [3.0]

Review of attachment 8902390 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with suggested change

::: devtools/client/themes/toolbox.css
@@ +39,5 @@
>    --command-measure-image: url(images/firebug/command-measure.svg);
>  }
>  
> +* {
> +  box-sizing: border-box

As we discussed, I'd prefer to move this into .devtools-tabbar for now. If we want to switch to box-sizing globally (in which case it would go in common.css and not toolbox.css) that should be a separate proposal / bug.
Attachment #8902390 - Flags: review?(bgrinstead) → review+
(Assignee)

Comment 9

3 months ago
Created attachment 8902502 [details] [diff] [review]
1391487.patch [4.0]
Attachment #8902502 - Flags: review+

Comment 10

3 months ago
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ddcc371a8852
DevTools toolbar should match the size of the Photon compact toolbar. r=bgrins
https://hg.mozilla.org/mozilla-central/rev/ddcc371a8852
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Screenshots:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=ae9e6b6d31321f119f1e07823f93137f58771377&newProject=mozilla-central&newRev=ab2d700fda2b4934d24227216972dce9fac19b74&filter=devtools
You need to log in before you can comment on or make changes to this bug.