1391487 - DevTools toolbar should match the size of the Photon compact toolbar

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

DevTools toolbar should match the size of the Photon compact toolbar. (29px tall)

http://searchfox.org/mozilla-central/source/browser/themes/shared/tabs.inc.css#16

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1391487.patch

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4b8bd3d68c8
DevTools toolbar should match the size of the Photon compact toolbar. r=bgrins

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out bug 1391487 and bug 1391478 for failing devtools' browser_inspector_highlighter-comments.js:

https://hg.mozilla.org/integration/mozilla-inbound/rev/6da32050f282bbd31bacfaa6897b2fbc5bc5e4fb
https://hg.mozilla.org/integration/mozilla-inbound/rev/023bb3482e57f4f0be17ed23c3ae3daedee47cf2

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=f4b8bd3d68c8f7b14e7c38f45c1c482f349ad704&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=124245229&repo=mozilla-inbound

[task 2017-08-18T21:41:23.689396Z] 21:41:23     INFO - Getting the markup-container for node #id4
[task 2017-08-18T21:41:23.693469Z] 21:41:23     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_highlighter-comments.js | Found markup-container for selector: #id4 - 
[task 2017-08-18T21:41:23.694421Z] 21:41:23     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_highlighter-comments.js | Highlighter is hidden - 
[task 2017-08-18T21:41:23.695741Z] 21:41:23     INFO - Hovering over a text node and waiting for highlighter to appear.
[task 2017-08-18T21:41:23.696544Z] 21:41:23     INFO - Hovering the text node "Visible text node" in the markup view
[task 2017-08-18T21:41:23.697699Z] 21:41:23     INFO - Buffered messages finished
[task 2017-08-18T21:41:23.699920Z] 21:41:23     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/test/browser_inspector_highlighter-comments.js | Test timed out - 
[task 2017-08-18T21:41:23.700994Z] 21:41:23     INFO - Removing tab.
[task 2017-08-18T21:41:23.701864Z] 21:41:23     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2017-08-18T21:41:23.703181Z] 21:41:23     INFO - Got event: 'TabClose' on [object XULElement].
[task 2017-08-18T21:41:23.704130Z] 21:41:23     INFO - Tab removed and finished closing

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1391487.patch [2.0]

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3041184cdc794b6f87aa4f296042d68e6d4f3ead

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1391487.patch [3.0]

Comment 7

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8902390 [details] [diff] [review]
1391487.patch [3.0]

Added * { box-sizing: border-box } for the toolbox. We want this toolbar to be 29px including the border. 

I think we are getting an intermittent in the test with this bigger toolbar because the Visible text node isn't visible in the markup view.

Comment 8

[Brian Grinstead [:bgrins]]

Comment on attachment 8902390 [details] [diff] [review]
1391487.patch [3.0]

Review of attachment 8902390 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with suggested change

::: devtools/client/themes/toolbox.css
@@ +39,5 @@
>    --command-measure-image: url(images/firebug/command-measure.svg);
>  }
>  
> +* {
> +  box-sizing: border-box

As we discussed, I'd prefer to move this into .devtools-tabbar for now. If we want to switch to box-sizing globally (in which case it would go in common.css and not toolbox.css) that should be a separate proposal / bug.

Comment 9

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1391487.patch [4.0]

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ddcc371a8852
DevTools toolbar should match the size of the Photon compact toolbar. r=bgrins

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ddcc371a8852

Comment 12

[Johann Hofmann [:johannh]]

Screenshots:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=ae9e6b6d31321f119f1e07823f93137f58771377&newProject=mozilla-central&newRev=ab2d700fda2b4934d24227216972dce9fac19b74&filter=devtools