Closed
Bug 1391532
Opened 8 years ago
Closed 8 years ago
Intermittent /service-workers/service-worker/registration-updateviacache.https.html | register-with-updateViaCache-all-then-none - assert_not_equals: Imported script should have updated got disallowed value 1503029624.95
Categories
(Core :: DOM: Service Workers, defect)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: bhsu)
References
(Blocks 1 open bug)
Details
(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:logic])
Attachments
(1 file)
1.71 KB,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
Updated•8 years ago
|
Blocks: ServiceWorkers-tests
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 3•8 years ago
|
||
I believe it has something to do with that :(
Let me investigate this. At this moment, I am very curious about the 15 failures last week. They all happened on osx, does that lead to anything helpful to solve this bug?
Assignee: nobody → bhsu
Flags: needinfo?(bhsu)
Comment 4•8 years ago
|
||
The mac-specific failures are probably just a timing issue. Do you have rr setup locally at all? Maybe this would reproduce under rr chaos mode.
Assignee | ||
Comment 5•8 years ago
|
||
Thanks, let me find a mac machine and setup an rr on it.
Assignee | ||
Comment 6•8 years ago
|
||
Oh, I just find out that we don't have rr for osx now, I am now falling back to my Linux...
Comment 7•8 years ago
|
||
Yea, I meant maybe rr chaos on Linux would trigger similar race condition we see on Mac. Sorry for my confusing comment.
Comment 8•8 years ago
|
||
this has 55 failures since August 18th:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1391532&startday=2017-08-17&endday=2017-08-24&tree=all
I ran across this and was excited to see work was being done on this already! Thanks for jumping on it.
Whiteboard: [stockwell needswork]
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 10•8 years ago
|
||
Hi Ben, and sorry again for not being able to reproduce this.
After thinking this case over, I humbly think the root cause is the precision
of the timestamp is too low which is 10^-2 sec in the testcase. By applying
this patch, we can make the precision reach to 10^-6 sec. Since it does no harm
to anything, I suggest we land this patch and checko how it would help.
Attachment #8902632 -
Flags: review?(bkelly)
Updated•8 years ago
|
Attachment #8902632 -
Flags: review?(bkelly) → review+
Assignee | ||
Comment 11•8 years ago
|
||
Keywords: checkin-needed
Comment 12•8 years ago
|
||
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c8a5a8f95aa
Preserve the precision of a timestamp when converting it to string. r=bkelly
Keywords: checkin-needed
Comment 13•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment hidden (Intermittent Failures Robot) |
Updated•8 years ago
|
Whiteboard: [stockwell needswork:owner] → [stockwell fixed:logic]
You need to log in
before you can comment on or make changes to this bug.
Description
•