Closed
Bug 1391533
Opened 7 years ago
Closed 7 years ago
Update sccache to 0.2.1
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
Update sccache to whatever revision https://github.com/mozilla/sccache/pull/178 ends up with when it's merged. That will solve the compiler warnings regressions observed in bug 1382502 comment 22 (https://treeherder.mozilla.org/perf.html#/alerts?id=8273) and bug 1387346 comment 12 (https://treeherder.mozilla.org/perf.html#/alerts?id=8644)
Assignee | ||
Updated•7 years ago
|
Summary: Update sccache to $revision → Update sccache to 0.2.1
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8898990 [details] Bug 1391533 - Update sccache to 0.2.1. https://reviewboard.mozilla.org/r/170322/#review175562
Attachment #8898990 -
Flags: review?(ted) → review+
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/2cccf2ec649c Update sccache to 0.2.1. r=ted
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2cccf2ec649c
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 5•7 years ago
|
||
Lots and lots of improvements on compiler warnings! The regressions bellow appeared only on windows. Ted, is there something we can do for these? I think we can accept them, given the old windows counts from https://bugzilla.mozilla.org/show_bug.cgi?id=1382502#c22 == Change summary for alert #8874 (as of August 18 2017 21:51 UTC) == Regressions: 6% compiler warnings summary windows2012-32 pgo 128.00 -> 136.00 6% compiler warnings summary windows2012-32 opt 128.00 -> 136.00 6% compiler warnings summary windows2012-32-noopt debug 133.00 -> 141.00 6% compiler warnings summary windows2012-32 debug 133.00 -> 141.00 5% compiler warnings summary windows2012-64 pgo 147.00 -> 155.00 5% compiler warnings summary windows2012-64 opt 147.00 -> 155.00 5% compiler warnings summary windows2012-64-noopt debug 153.00 -> 161.00 5% compiler warnings summary windows2012-64 debug 153.00 -> 161.00 Improvements: 97% compiler warnings summary linux64 asan asan debug 11,827.00 -> 326.00 97% compiler warnings summary linux64 asan asan opt 9,579.00 -> 295.00 97% compiler warnings summary linux64 asan asan-fuzzing 9,539.00 -> 297.00 97% compiler warnings summary linux64 opt static-analysis 9,290.00 -> 297.00 95% compiler warnings summary osx-cross opt 6,547.00 -> 296.00 95% compiler warnings summary osx-cross-noopt debug 7,278.42 -> 330.00 95% compiler warnings summary osx-cross debug 7,044.75 -> 330.00 95% compiler warnings summary linux64 debug static-analysis6,406.00 -> 328.00 5% compiler warnings summary linux64-noopt debug 297.00 -> 283.00 5% compiler warnings summary linux32 pgo 1,466.50 -> 1,399.00 5% compiler warnings summary linux64 pgo 1,509.92 -> 1,440.92 3% compiler warnings summary linux64 debug base-toolchains414.00 -> 399.67 3% compiler warnings summary linux32 debug 414.00 -> 399.67 3% compiler warnings summary linux64 debug 414.00 -> 399.67 3% compiler warnings summary android-4-0-armv7-api15 debug 440.00 -> 425.00 3% compiler warnings summary linux32 opt 467.00 -> 453.00 3% compiler warnings summary android-4-2-x86 opt 1,193.00 -> 1,158.00 3% compiler warnings summary android-api-15-gradle opt 1,186.00 -> 1,153.33 3% compiler warnings summary android-4-0-armv7-api15 opt 1,186.00 -> 1,153.33 3% compiler warnings summary android-5-0-aarch64 opt 1,207.00 -> 1,175.00 3% compiler warnings summary linux64 opt valgrind 484.00 -> 471.33 2% compiler warnings summary linux64 opt base-toolchains 483.00 -> 471.00 2% compiler warnings summary linux64 opt 483.00 -> 471.00 For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=8874
Flags: needinfo?(ted)
Comment 6•7 years ago
|
||
The improvements were expected, that was a big part of the reason glandium made this change. I suspect the increase in warnings is because sccache was hiding a few warnings before. This was filed upstream as https://github.com/mozilla/sccache/issues/72 , and fixed by glandium's change. As such, I think those are valid warnings that we just weren't seeing previously. The increases are also very small, so it doesn't seem harmful.
Flags: needinfo?(ted)
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•