Closed Bug 1391541 Opened 4 years ago Closed 4 years ago

Fix svg mask image in layers-free mode

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: ethlin, Assigned: ethlin)

References

Details

Attachments

(1 file)

After bug 1390804, there are still some failures those are related to svg mask (e.g., layout/reftests/border-radius/corner-joins-1.xhtml). That's because the nsDisplayMask::PaintMask couldn't render every kind of mask image. For layers mode, some will fall back to nsDisplayMask::PaintAsLayer.
It's a transform problem. I already have a wip. I will upload it and do more checks before sending review request.
Currently APZ seems to break the test. So I tested the reftest with APZ disabled.
Comment on attachment 8898713 [details]
Bug 1391541 - Correct the transform for layers-free fallback.

https://reviewboard.mozilla.org/r/170118/#review176754

If it makes tests pass better it must be right! :)
Attachment #8898713 - Flags: review?(bugmail) → review+
Pushed by ethlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/709127d9e27f
Correct the transform for layers-free fallback. r=kats
https://hg.mozilla.org/mozilla-central/rev/709127d9e27f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.