Closed Bug 1391551 Opened 4 years ago Closed 3 years ago

(photon) Drop photon skin flavor

Categories

(Firefox Build System :: Android Studio and Gradle Integration, enhancement, P5)

Unspecified
Android
enhancement

Tracking

(firefox57 affected, firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
firefox57 --- affected
firefox65 --- fixed

People

(Reporter: jwu, Assigned: nalexander)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Since we have removed Australis flavor in bug 1375351, the skin flavorDimensions  and photon flavor in build.gradle aren't necessary anymore. 

When most of the Photon visual refresh works are finished, we would like to drop Photon flavor. What we need to do includes:

1. Remove Photon flavor in build.gradle
2. Move all resource files from "app/src/photon/res/" to "app/src/main/res/"
3. Move all Java files from "app/src/photon/java/" to "base/java/"
4. Refactor Fennec build scripts that have hardcoded "photon" in it.
Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.
Priority: -- → P5
Assignee: nobody → nalexander
Blocks: 1500607
Status: NEW → ASSIGNED
sdaswani: please assign to an appropriate Fennec reviewer.  This is pretty mechanical; if https://treeherder.mozilla.org/#/jobs?repo=try&revision=27dd801d6356169f68de9f5b974524f2ed253fe3 is green, it should be fine to land.
Flags: needinfo?(sdaswani)
(In reply to Nick Alexander :nalexander [he/him] from comment #3)
> sdaswani: please assign to an appropriate Fennec reviewer.  This is pretty
> mechanical; if
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=27dd801d6356169f68de9f5b974524f2ed253fe3 is green, it
> should be fine to land.

The lint error at https://treeherder.mozilla.org/#/jobs?repo=try&revision=27dd801d6356169f68de9f5b974524f2ed253fe3&selectedJob=206713531 is real; it was previously ignored: https://searchfox.org/mozilla-central/rev/fcfb479e6ff63aea017d063faa17877ff750b4e5/mobile/android/app/lint.xml#65.  I'll ignore it when landing this.
done, thanks Nick.
Flags: needinfo?(sdaswani)
Blocks: 1501053
Pushed by nalexander@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9397caac8090
Drop Fennec skin flavor dimension. r=petru
Pushed by nalexander@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/01142b0fa51e
Drop Fennec skin flavor dimension. r=petru
(In reply to Andrei Ciure[:andrei_ciure_] from comment #7)
> Backed out 2 changesets (bug 1501053, bug 1391551) for causing lint build
> bustages
> 
> push that caused the backout:
> https://treeherder.mozilla.org/#/
> jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedSta
> te=unclassified&selectedJob=207832114&revision=9397caac80907d5f9a1e79fbcc0774
> f742efd6fa
> 
> failures:
> https://treeherder.mozilla.org/#/
> jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedSta
> te=unclassified&fromchange=8c16d6956679cac8745372056217ddb257f05171&selectedJ
> ob=207837386&searchStr=android%2C4.
> 0%2Capi16%2B%2Copt%2Candroid%2Cgradle%2Ctests%2Cbuild-android-
> lint%2Fopt%2Ca%28lint%29
> 
> backout:
> https://hg.mozilla.org/integration/autoland/rev/
> 4e1ac8b657be50febe961899ddeab9b001906fa0

This was 100% on me -- sorry for the time wasted.  I didn't push my fresh local versions to Phab before landing :(
Flags: needinfo?(nalexander)
https://hg.mozilla.org/mozilla-central/rev/01142b0fa51e
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 65 → mozilla65
You need to log in before you can comment on or make changes to this bug.