Closed Bug 1391563 Opened 5 years ago Closed 5 years ago

Check if exporting EventEmitter.emit from devtools/shared/protocol is still necessary

Categories

(DevTools :: General, enhancement, P1)

enhancement

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

(Whiteboard: [reserve-nosdk])

Attachments

(1 file)

Follow up to Bug 1137935.

We should check if exporting EventEmitter.emit is still necessary after migrating out of the sdk event emitter:
http://searchfox.org/mozilla-central/rev/e8c36327cd8c9432c69e5e1383156a74330f11f2/devtools/shared/protocol.js#15
Simply removed the export and tested locally, seems to be fine.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=96b19b96c5acd47ac2fb3aa4f98c4a37a7e63f67
Whiteboard: [nosdk]
Flags: qe-verify-
Priority: P3 → P1
Target Milestone: --- → Firefox 57
Whiteboard: [nosdk] → [reserve-nosdk]
Try seems to be ok with it.

Just sent another push rebased on the latest central: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ff7f541d86bb3e980f62b6dd35a4d2b3eeb69e9
Comment on attachment 8898823 [details]
Bug 1391563 - stop exporting event-emitter emit method from devtools protocol.js;

https://reviewboard.mozilla.org/r/170198/#review176940
Attachment #8898823 - Flags: review?(poirot.alex) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e2a683f3be4f
stop exporting event-emitter emit method from devtools protocol.js;r=ochameau
https://hg.mozilla.org/mozilla-central/rev/e2a683f3be4f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.