Check if exporting EventEmitter.emit from devtools/shared/protocol is still necessary

RESOLVED FIXED in Firefox 57

Status

P1
normal
RESOLVED FIXED
a year ago
6 months ago

People

(Reporter: jdescottes, Assigned: jdescottes)

Tracking

unspecified
Firefox 57
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [reserve-nosdk])

Attachments

(1 attachment)

Follow up to Bug 1137935.

We should check if exporting EventEmitter.emit is still necessary after migrating out of the sdk event emitter:
http://searchfox.org/mozilla-central/rev/e8c36327cd8c9432c69e5e1383156a74330f11f2/devtools/shared/protocol.js#15
Comment hidden (mozreview-request)
Simply removed the export and tested locally, seems to be fine.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=96b19b96c5acd47ac2fb3aa4f98c4a37a7e63f67
Whiteboard: [nosdk]
Flags: qe-verify-
Priority: P3 → P1
Target Milestone: --- → Firefox 57
Whiteboard: [nosdk] → [reserve-nosdk]
Comment hidden (mozreview-request)
Try seems to be ok with it.

Just sent another push rebased on the latest central: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ff7f541d86bb3e980f62b6dd35a4d2b3eeb69e9

Comment 5

a year ago
mozreview-review
Comment on attachment 8898823 [details]
Bug 1391563 - stop exporting event-emitter emit method from devtools protocol.js;

https://reviewboard.mozilla.org/r/170198/#review176940
Attachment #8898823 - Flags: review?(poirot.alex) → review+

Comment 6

a year ago
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e2a683f3be4f
stop exporting event-emitter emit method from devtools protocol.js;r=ochameau
https://hg.mozilla.org/mozilla-central/rev/e2a683f3be4f
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED

Updated

6 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.