Closed Bug 1391575 Opened 2 years ago Closed 2 years ago
Make MMA GCM Sender ID configurable
59 bytes, text/x-review-board-request
In bug 1386151, we added a new GCM sender ID and hard-coded in MmaConstant. We might want to add it back.
Assignee: nobody → cnevinchen
Depends on: 1386151
Priority: -- → P2
Hi Nick Should I put MMA GCM sender id in configure.sh in branding folder, or like the patch in old-configure.in ? Do you think I should put it in leanplum-sdk-xxxx.token ? Thank you!
Comment on attachment 8898717 [details] Bug 1391575 - Move MMA GCM sender ID to config file https://reviewboard.mozilla.org/r/170126/#review175400 I didn't check all the details, but I'm fine with this approach. It's not worth untangling the branding configure stuff from `old-configure.in` at this time. ::: old-configure.in:4873 (Diff revision 1) > AC_SUBST(MOZ_APP_PROFILE) > AC_SUBST(MOZ_APP_ID) > AC_SUBST(MOZ_APP_ANDROID_VERSION_CODE) > AC_SUBST(MOZ_ANDROID_SHARED_ID) > AC_SUBST(MOZ_ANDROID_GCM_SENDERID) > +AC_SUBST(MOZ_MMA_GCM_SENDERID) Include the corresponding comment, like at http://searchfox.org/mozilla-central/source/old-configure.in#4676.
Attachment #8898717 - Flags: review?(nalexander) → review+
Comment on attachment 8898717 [details] Bug 1391575 - Move MMA GCM sender ID to config file https://reviewboard.mozilla.org/r/170126/#review176138
Attachment #8898717 - Flags: review?(max) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/4cb2de15167b Move MMA GCM sender ID to config file r=maliu,nalexander
Whiteboard: [FNC][SPT57.2][INT] → [FNC][SPT57.2][INT][SP=X, 2]
You need to log in before you can comment on or make changes to this bug.