Closed
Bug 1391578
Opened 7 years ago
Closed 7 years ago
"Report deceptive site…" menu item should use title capitalization
Categories
(Firefox :: Menus, enhancement)
Firefox
Menus
Tracking
()
VERIFIED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | verified |
People
(Reporter: dao, Assigned: akriti.v10, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
In the Help menu, the "Report deceptive site…" item should be labeled "Report Deceptive Site…" instead. This needs to be fixed in browser/locales/en-US/chrome/browser/safebrowsing/report-phishing.dtd.
Assignee | ||
Comment 1•7 years ago
|
||
Hi, I would like to make the specified changes. Please assign this to me.
Flags: needinfo?(dao+bmo)
Reporter | ||
Comment 2•7 years ago
|
||
Sure! Let me know if you have questions.
Assignee: nobody → akriti.v10
Flags: needinfo?(dao+bmo)
Assignee | ||
Comment 3•7 years ago
|
||
hi Dao, I am getting this error "cannot submit reviews referencing multiple bugs" while pushing for review. What can be the possible reason for it.
Flags: needinfo?(dao+bmo)
Reporter | ||
Comment 4•7 years ago
|
||
You can see your commits using hg out. You likely made another commit before this one. If you want to submit only the latest commit, use: hg push review -c tip Although at some point you should probably clean this up and remove any old commit(s) using hg strip tip.
Flags: needinfo?(dao+bmo)
Comment hidden (mozreview-request) |
Reporter | ||
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8899525 [details] Bug 1391578 - title capitalization done for the menu item https://reviewboard.mozilla.org/r/170806/#review176010 Thanks!
Attachment #8899525 -
Flags: review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/25731ae36331 title capitalization done for the menu item r=dao
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/25731ae36331
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment 9•7 years ago
|
||
I have reproduced this Bug on Nightly 57.0a1 (2017-08-18) on Ubuntu 16.04 LTS! This bug's fix is verified with latest Nightly! Build ID : 20170829100404 User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
QA Whiteboard: [bugday-20170830]
Comment 10•7 years ago
|
||
I have reproduced this Bug on Nightly 57.0a1 (2017-08-18) on on Windows 8.1! This bug's fix is verified with latest Nightly! Build ID : 20170829100404 User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:57.0) Gecko/20100101 Firefox/57.0 [bugday-20170830]
Comment 11•7 years ago
|
||
As per Comment 9 and Comment 10, I am marking this bug as verified fixed!
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•