Status

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Callek, Assigned: Callek)

Tracking

unspecified

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(4 attachments)

We should encourage testing on try for l10n... Currently this is hard.
Comment on attachment 8898826 [details]
Bug 1391643 - Make sure we use dep signing worker when using the dep signing scope.

https://reviewboard.mozilla.org/r/170206/#review175416

::: taskcluster/taskgraph/transforms/checksums_signing.py:108
(Diff revision 1)
>          yield task
> +
> +
> +def _generate_worker_type(signing_cert_scope):
> +    worker_type = 'depsigning' if 'dep-signing' in signing_cert_scope else 'signing-linux-v1'
> +    return 'scriptworker-prov-v1/{}'.format(worker_type)

We're duplicating this function -- it probably makes sense to put it in `util.scriptworker` and import it.
Attachment #8898826 - Flags: review?(aki) → review+
Comment on attachment 8898828 [details]
Bug 1391643 - Make android single locale testable on try.

https://reviewboard.mozilla.org/r/170210/#review175418

The `nightly_build=True` threw me off a bit, but if we can't get single locale testing otherwise, it makes sense to make it testable.
Attachment #8898828 - Flags: review?(aki) → review+
Comment on attachment 8898827 [details]
Bug 1391643 - Set macbundle prefix on nightly-try too.

https://reviewboard.mozilla.org/r/170208/#review175428

This is odd to me, since we use "FirefoxNightly" for the osx macbundlename-prefix; do we change that later?
It seems to work for the nightly channel, though.
This shouldn't affect merge day at all.
Attachment #8898827 - Flags: review?(aki) → review+
Comment on attachment 8898946 [details]
Bug 1391643 - Build stub installer when building Nightly on try.

https://reviewboard.mozilla.org/r/170242/#review175512

I'm fine with this but you should get mhowell who owns the installer to review this
Attachment #8898946 - Flags: review?(robert.strong.bugs)
Attachment #8898946 - Flags: review?(mhowell)
Comment on attachment 8898946 [details]
Bug 1391643 - Build stub installer when building Nightly on try.

https://reviewboard.mozilla.org/r/170242/#review175536
Attachment #8898946 - Flags: review?(mhowell) → review+
Comment on attachment 8898826 [details]
Bug 1391643 - Make sure we use dep signing worker when using the dep signing scope.

https://reviewboard.mozilla.org/r/170206/#review175416

> We're duplicating this function -- it probably makes sense to put it in `util.scriptworker` and import it.

Done
Comment on attachment 8898827 [details]
Bug 1391643 - Set macbundle prefix on nightly-try too.

https://reviewboard.mozilla.org/r/170208/#review175428

This was needed otherwise the OSX Repack code wouldn't find the right things. Its possible we can clean this up, but it will certainly be a lot easier to clean up once L10n is only in TC
Hey mike, I'm about to stop entirely for a 2 wk PTO. Once you review can you schedule this to autoland please?
Flags: needinfo?(mh+mozilla)
Comment on attachment 8898827 [details]
Bug 1391643 - Set macbundle prefix on nightly-try too.

https://reviewboard.mozilla.org/r/170208/#review176092
Attachment #8898827 - Flags: review?(mh+mozilla) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/5ac4ef0d29d9
Make sure we use dep signing worker when using the dep signing scope. r=aki
https://hg.mozilla.org/integration/autoland/rev/9312a1903bf4
Set macbundle prefix on nightly-try too. r=aki,glandium
https://hg.mozilla.org/integration/autoland/rev/b8e41afb9e91
Make android single locale testable on try. r=aki
https://hg.mozilla.org/integration/autoland/rev/2528a12e8ba3
Build stub installer when building Nightly on try. r=mhowell
Flags: needinfo?(mh+mozilla)
You need to log in before you can comment on or make changes to this bug.