1391657 - Mozilla Firefox Nightly 57.0a1 (2017-08-18) crashes in [@ mozilla::PrioritizedEventQueue<T>::EnablePrioritizationRunnable::Run ] with prioritized_input_events.enabled=true after landing patch from bug #1382922

Status: VERIFIED FIXED

(Core :: XPCOM, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

"Speedy" Regression window (mozilla-central)
Good:
https://ftp.mozilla.org/pub/firefox/nightly/2017/08/2017-08-17-10-01-32-mozilla-central/

Bad:
https://ftp.mozilla.org/pub/firefox/nightly/2017/08/2017-08-18-10-02-26-mozilla-central/

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=932388b8c22c9775264e543697ce918415db9e23&tochange=a6a1f5c1d971dbee67ba6eec7ead7902351ddca2

Probably caused by:
Kaspersky AV and some bug from pushlog above

Comment 1

[Andrew McCreight [:mccr8]]

Bill, could this be a regression from bug 1382922 (which is in the regression window)? Or maybe just a signature change?

Comment 2

[Andrew McCreight [:mccr8]]

Can you reproduce this? What are the steps? Just install Kaspersky and load the browser?

Comment 3

[Andrew McCreight [:mccr8]]

I see 86 crashes (which is a lot!) but from only 3 installations.

Comment 4

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

STR:
1. Open "about:config"
2. Search for "prioritized_input_events.enabled"
3. Change it to "true" from "false"
4. Restart browser
and enjoy crashes even with opening new tab

Comment 5

[randomreporter]

(In reply to Andrew McCreight [:mccr8] from comment #3)
> I see 86 crashes (which is a lot!) but from only 3 installations.

I guess that's my 3 profiles. Here is crash stats:
https://crash-stats.mozilla.com/report/index/bp-3f409935-b27f-453a-87fc-a070f0170818
Use STR from Comment 4.

I also reported this crash here: https://bugzilla.mozilla.org/show_bug.cgi?id=1390044#c1

Comment 6

[Andrew McCreight [:mccr8]]

Thanks. Alright, so this doesn't have anything to do with Kaspersky. I can also reproduce this. Warning: don't try to reproduce this in your main profile as it totally wrecks your tab state. ;)

Comment 7

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

Oops. Forgot to initialize a member.

Comment 8

[Andrew McCreight [:mccr8]]

Comment on attachment 8898971 [details] [diff] [review]
patch

Review of attachment 8898971 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/threads/PrioritizedEventQueue.cpp
@@ +304,5 @@
>  {
>  public:
>    explicit EnablePrioritizationRunnable(PrioritizedEventQueue<InnerQueueT>* aQueue)
>      : Runnable("EnablePrioritizationRunnable")
> +    , mQueue(aQueue)

I guess this queue is some kind of global data structure so you don't have to worry about the runnable outliving the queue while holding this weak pointer?

Comment 9

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

(In reply to Andrew McCreight [:mccr8] from comment #8)
> I guess this queue is some kind of global data structure so you don't have
> to worry about the runnable outliving the queue while holding this weak
> pointer?

It's the event queue. If we don't have that anymore, then we can't be processing events. So the runnable wouldn't have run. I'll add a comment.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6fa486012b34
Fix missing member initialization for input prioritization (r=mccr8)

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/6fa486012b34

Comment 12

[Nicholas Nethercote [inactive]]

No sign of this crash in Nightly 20170820100343!

Comment 13

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 57.0a1 (2017-08-20), so I'm marking this bug as VERIFIED. Thank you very much! \o/