Closed
Bug 1391665
Opened 7 years ago
Closed 7 years ago
Port Bug 945627. Remove FIXUP_FLAG_USE_UTF8 in SeaMonkey.
Categories
(SeaMonkey :: General, enhancement)
SeaMonkey
General
Tracking
(seamonkey2.49esr fixed, seamonkey2.50 wontfix, seamonkey2.51 wontfix, seamonkey2.52 wontfix, seamonkey2.54 fixed, seamonkey2.53 fixed)
RESOLVED
FIXED
seamonkey2.54
People
(Reporter: frg, Assigned: frg)
References
Details
Attachments
(1 file)
|
8.56 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-beta+
iannbugzilla
:
approval-comm-esr52+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #945627 +++ Bug 393246 obsoleted FIXUP_FLAG_USE_UTF8. Bug 945627 removed it from the source tree. It is still referenced in SeaMonkey source code.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8898822 -
Flags: review?(iann_bugzilla)
|
|
Assignee | |
Updated•7 years ago
|
Status: NEW → ASSIGNED
Comment on attachment 8898822 [details] [diff] [review] 1391665-isUTF8.patch LGTM r=me
Attachment #8898822 -
Flags: review?(iann_bugzilla) → review+
Pushed by frgrahl@gmx.net: https://hg.mozilla.org/comm-central/rev/fd780befc796 Port Bug 942657. Remove FIXUP_FLAG_USE_UTF8 in SeaMonkey. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•7 years ago
|
Target Milestone: --- → seamonkey2.54
|
|
Assignee | |
Comment 4•7 years ago
|
||
Comment on attachment 8898822 [details] [diff] [review] 1391665-isUTF8.patch [Approval Request Comment] Regression caused by (bug #): 942657 User impact if declined: none I just like to be tabbrowser.xml to be "nice and clean". It references an undefined variable here. Testing completed (on m-c, etc.): c-c Risk to taking this patch (and alternatives if risky): none String changes made by this patch: none
Attachment #8898822 -
Flags: approval-comm-esr52?
Attachment #8898822 -
Flags: approval-comm-beta?
|
|
Assignee | |
Updated•7 years ago
|
Summary: Port Bug 942657. Remove FIXUP_FLAG_USE_UTF8 in SeaMonkey. → Port Bug 945657. Remove FIXUP_FLAG_USE_UTF8 in SeaMonkey.
|
|
Assignee | |
Updated•7 years ago
|
Summary: Port Bug 945657. Remove FIXUP_FLAG_USE_UTF8 in SeaMonkey. → Port Bug 945627. Remove FIXUP_FLAG_USE_UTF8 in SeaMonkey.
Pushed by frgrahl@gmx.net: https://hg.mozilla.org/comm-central/rev/06cf296b7904 Backed out changeset: fd780befc796 for referencing the wrong bug in the comment. https://hg.mozilla.org/comm-central/rev/88f097d5e664 Port Bug 945627. Remove FIXUP_FLAG_USE_UTF8 in SeaMonkey. r=IanN
|
|
Assignee | |
Comment 6•7 years ago
|
||
Backout and repush. Sorry I bungled the comment. https://hg.mozilla.org/comm-central/rev/06cf296b790425972127eef26ffa6c74a5ff9d9a https://hg.mozilla.org/comm-central/rev/88f097d5e6646a5898cf05d3ab05a8f6aee2f841
Comment on attachment 8898822 [details] [diff] [review] 1391665-isUTF8.patch a=me for both repos
Attachment #8898822 -
Flags: approval-comm-esr52?
Attachment #8898822 -
Flags: approval-comm-esr52+
Attachment #8898822 -
Flags: approval-comm-beta?
Attachment #8898822 -
Flags: approval-comm-beta+
|
|
Assignee | |
Comment 8•7 years ago
|
||
https://hg.mozilla.org/releases/comm-beta/rev/ee408dcd42c54233b1b44d12b22537f58584575d https://hg.mozilla.org/releases/comm-esr52/rev/e1ff44e7aadcafc876d36032aecbc0b24dc1e4a5
You need to log in
before you can comment on or make changes to this bug.
Description
•