Closed Bug 1391680 Opened 7 years ago Closed 7 years ago

Release graph needs to specify mar_sha384 signing for releases >= 56.0b4

Categories

(Release Engineering :: Release Automation: Other, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: catlee, Assigned: jlorenzo)

References

Details

Attachments

(3 files)

      No description provided.
Assignee: nobody → jlorenzo
Attachment #8898865 - Flags: review?(mtabara)
Comment on attachment 8898865 [details] [review]
releasetasks PR (real fix)

Review of attachment 8898865 [details] [review]:
-----------------------------------------------------------------

We need to fix the tests.
Attachment #8898865 - Attachment is patch: true
Attachment #8898865 - Attachment mime type: text/x-github-pull-request → text/plain
Attachment #8898865 - Flags: review?(mtabara) → review-
Comment on attachment 8898863 [details]
Bug 1391680 - Pass mar_signing_format to releasetasks

https://reviewboard.mozilla.org/r/170230/#review175412

The check seems good! 
However, along release-runner, we'd still need to add the same check under:
a) __init__.py[1] - both in the function parameters and the sanitizer dict 
b) under releasetasks_graph_gen.py[2] since it'll fail at the next dot release because it won't know who the argument is from a) 

[1]: https://dxr.mozilla.org/build-central/source/tools/lib/python/kickoff/__init__.py#279
[2]: https://hg.mozilla.org/build/tools/file/tip/buildfarm/release/releasetasks_graph_gen.py
Attachment #8898863 - Flags: review?(mtabara) → review-
Attachment #8898865 - Attachment is patch: false
Attachment #8898865 - Attachment mime type: text/plain → text/x-github-pull-request
Attachment #8898865 - Flags: review- → review?(mtabara)
Comment on attachment 8898863 [details]
Bug 1391680 - Pass mar_signing_format to releasetasks

https://reviewboard.mozilla.org/r/170230/#review175448

Nice!
Attachment #8898863 - Flags: review?(mtabara) → review+
Attachment #8898865 - Flags: review?(mtabara) → review+
Both releasetasks PR and tools patch are now on bm85 + supervisorctl restart.
New partials for 56.0b4-build4 look good.
Thanks for the help with this!
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
See Also: → 1391297
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: