Closed
Bug 1391680
Opened 7 years ago
Closed 7 years ago
Release graph needs to specify mar_sha384 signing for releases >= 56.0b4
Categories
(Release Engineering :: Release Automation: Other, enhancement)
Release Engineering
Release Automation: Other
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: catlee, Assigned: jlorenzo)
References
Details
Attachments
(3 files)
59 bytes,
text/x-review-board-request
|
mtabara
:
review+
mtabara
:
checked-in+
|
Details |
55 bytes,
text/x-github-pull-request
|
Details | Review | |
55 bytes,
text/x-github-pull-request
|
mtabara
:
review+
mtabara
:
checked-in+
|
Details | Review |
No description provided.
Reporter | ||
Comment 1•7 years ago
|
||
There are a few places in the release graph that hardcode the old 'mar' signing format: https://github.com/mozilla-releng/releasetasks/blob/master/releasetasks/templates/desktop/l10n.yml.tmpl#L299 https://github.com/mozilla-releng/releasetasks/blob/master/releasetasks/templates/desktop/enUS.yml.tmpl#L225 https://github.com/mozilla-releng/releasetasks/blob/master/releasetasks/templates/desktop/release_graph.yml.tmpl#L47 These should be parameterized and use 'mar_sha384' for 56.0b4 and higher.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jlorenzo
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #8898865 -
Flags: review?(mtabara)
Comment 5•7 years ago
|
||
Comment on attachment 8898865 [details] [review] releasetasks PR (real fix) Review of attachment 8898865 [details] [review]: ----------------------------------------------------------------- We need to fix the tests.
Attachment #8898865 -
Attachment is patch: true
Attachment #8898865 -
Attachment mime type: text/x-github-pull-request → text/plain
Attachment #8898865 -
Flags: review?(mtabara) → review-
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8898863 [details] Bug 1391680 - Pass mar_signing_format to releasetasks https://reviewboard.mozilla.org/r/170230/#review175412 The check seems good! However, along release-runner, we'd still need to add the same check under: a) __init__.py[1] - both in the function parameters and the sanitizer dict b) under releasetasks_graph_gen.py[2] since it'll fail at the next dot release because it won't know who the argument is from a) [1]: https://dxr.mozilla.org/build-central/source/tools/lib/python/kickoff/__init__.py#279 [2]: https://hg.mozilla.org/build/tools/file/tip/buildfarm/release/releasetasks_graph_gen.py
Attachment #8898863 -
Flags: review?(mtabara) → review-
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8898865 -
Attachment is patch: false
Attachment #8898865 -
Attachment mime type: text/plain → text/x-github-pull-request
Attachment #8898865 -
Flags: review- → review?(mtabara)
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8898863 [details] Bug 1391680 - Pass mar_signing_format to releasetasks https://reviewboard.mozilla.org/r/170230/#review175448 Nice!
Attachment #8898863 -
Flags: review?(mtabara) → review+
Updated•7 years ago
|
Attachment #8898865 -
Flags: review?(mtabara) → review+
Comment 9•7 years ago
|
||
Comment on attachment 8898865 [details] [review] releasetasks PR (real fix) https://github.com/mozilla-releng/releasetasks/commit/dc89be76b50b5a1c4723d144da6cfdfc2118ae2c
Attachment #8898865 -
Flags: checked-in+
Comment 10•7 years ago
|
||
Comment on attachment 8898863 [details] Bug 1391680 - Pass mar_signing_format to releasetasks https://hg.mozilla.org/build/tools/rev/23a0ecce9979
Attachment #8898863 -
Flags: checked-in+
Comment 11•7 years ago
|
||
Both releasetasks PR and tools patch are now on bm85 + supervisorctl restart.
Comment 12•7 years ago
|
||
New partials for 56.0b4-build4 look good. Thanks for the help with this!
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•