Closed Bug 1391705 Opened 7 years ago Closed 7 years ago

Don't offer context menu on devices in Send Page to Device subview

Categories

(Firefox :: General, defect, P1)

57 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 57
Iteration:
57.2 - Aug 29
Tracking Status
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- verified

People

(Reporter: rfeeley, Assigned: Gijs)

References

Details

(Whiteboard: [reserve-photon-structure])

Attachments

(2 files)

Attached image context-menu.png
STEPS TO REPRODUCE
1. Be syncing at least two devices
2. Open Page Action Menu
3. Open Send Page to Device
4. Right-click on device name

EXPECTED RESULTS
- Nothing happens

ACTUAL RESULTS
- Add to Address context menu item appears
- Selecting it does nothing
Component: Sync → General
Blocks: 1374477, 1387512
Whiteboard: [reserve-photon-structure]
Version: 55 Branch → 57 Branch
I think this should be as simple as moving the context/contextmenu attribute to the main view of the page action popup.
Flags: qe-verify?
Priority: -- → P3
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 57.2 - Aug 29
Priority: P3 → P1
When fixing this I realized you could context-click on empty bits of the main view in the panel and we'd show the context menu and it wouldn't do anything, so I fixed that too. :-)
Comment on attachment 8900241 [details]
Bug 1391705 - don't show context menu except on toolbarbuttons on the main view,

https://reviewboard.mozilla.org/r/171628/#review176988

Thank you
Attachment #8900241 - Flags: review?(adw) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4f0c2d08aa32
don't show context menu except on toolbarbuttons on the main view, r=adw
https://hg.mozilla.org/mozilla-central/rev/4f0c2d08aa32
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Flags: qe-verify? → qe-verify+
QA Contact: gwimberly
I have reproduced the issue mentioned in comment 0 using an affected Firefox 57.0a1 build (BuildId:20170818100226).

I have verified that the issue is not reproducible using Firefox 57.0b7 (Build Id:20171009192146) on Windows 10 64bit, macOS 10.11.6 and Ubuntu 16.04 64bit.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: