1391720 - remove _blank support in extension protocol

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P3)

Description

[Shane Caraveo (:mixedpuppy)]

_blank.html was onced used as the background page, but no longer.  Code still exists for it.

ExtensionProtocolHandler::ResolveSpecialCases and ext-backgroundPage.js

Need to also verify that the schema enforces ExtensionURL for the background page.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1391720 remove _blank support for background pages,

Review commit: https://reviewboard.mozilla.org/r/170302/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/170302/

Comment 2

[Shane Caraveo (:mixedpuppy)]

I've verified ExtensionURL is used in schema.

Comment 3

[Kris Maglione [:kmag]]

Comment on attachment 8898934 [details]
Bug 1391720 remove _blank support for background pages,

https://reviewboard.mozilla.org/r/170302/#review175488

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7905ab8c8041
remove _blank support for background pages, r=kmag

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing mochitest caps/tests/mochitest/test_extensionURL.html:

https://hg.mozilla.org/integration/autoland/rev/6594d380018e650090e225353fa4ebb5092f9087

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=7905ab8c80414c9d61a2a6cad3066bc2c1031a82&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=runnable&filter-resultStatus=usercancel
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=124225686&repo=autoland

14:12:31     INFO - TEST-PASS | caps/tests/mochitest/test_extensionURL.html | Principal uri is correct: moz-extension://cherise/resource_test_file.html 
14:12:31     INFO - TEST-PASS | caps/tests/mochitest/test_extensionURL.html | Principal origin is correct: moz-extension://cherise 
14:12:31     INFO - TEST-PASS | caps/tests/mochitest/test_extensionURL.html | addonId is correct 
14:12:31     INFO - TEST-PASS | caps/tests/mochitest/test_extensionURL.html | document looks right 
14:12:31     INFO - TEST-PASS | caps/tests/mochitest/test_extensionURL.html | Correct throwing behavior for: moz-extension://cherise/_blank.html 
14:12:31     INFO - Buffered messages finished
14:12:31     INFO - TEST-UNEXPECTED-FAIL | caps/tests/mochitest/test_extensionURL.html | Test timed out. 
14:12:31     INFO -     reportError@SimpleTest/TestRunner.js:121:7
14:12:31     INFO -     TestRunner._checkForHangs@SimpleTest/TestRunner.js:142:7
14:12:31     INFO -     setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
14:12:31     INFO -     setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
14:12:31     INFO -     setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
14:12:31     INFO -     setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
14:12:31     INFO -     setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
14:12:31     INFO -     setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
14:12:31     INFO -     setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
14:12:31     INFO -     setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
14:12:31     INFO -     setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
14:12:31     INFO -     setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
14:12:31     INFO -     setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
14:12:31     INFO -     TestRunner.runTests@SimpleTest/TestRunner.js:380:5
14:12:31     INFO -     RunSet.runtests@SimpleTest/setup.js:194:3
14:12:31     INFO -     RunSet.runall@SimpleTest/setup.js:173:5
14:12:31     INFO -     hookupTests@SimpleTest/setup.js:266:5
14:12:31     INFO - EventHandlerNonNull*getTestManifest@http://mochi.test:8888/manifestLibrary.js:45:3
14:12:31     INFO -     hookup@SimpleTest/setup.js:246:5
14:12:31     INFO - EventHandlerNonNull*@http://mochi.test:8888/tests?autorun=1&closeWhenDone=1&consoleLevel=INFO&hideResultsTable=1&manifestFile=tests.json&dumpOutputDirectory=%2Fvar%2Ffolders%2Fdx%2Fw04m90ps63q5j9l0th109tzr00000w%2FT&cleanupCrashes=true:11:1

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This also has at least one failing browser-chrome test: https://treeherder.mozilla.org/logviewer.html#?job_id=124225640&repo=autoland

14:23:22     INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_tabs_executeScript_good.js | Expect widget not to be overflowed - 
14:23:22     INFO - Console message: OpenGL compositor Initialized Succesfully.
14:23:22     INFO - Version: 2.1 INTEL-10.6.33
14:23:22     INFO - Vendor: Intel Inc.
14:23:22     INFO - Renderer: Intel Iris OpenGL Engine
14:23:22     INFO - FBO Texture Target: TEXTURE_2D
14:23:22     INFO - Console message: OpenGL compositor Initialized Succesfully.
14:23:22     INFO - Version: 2.1 INTEL-10.6.33
14:23:22     INFO - Vendor: Intel Inc.
14:23:22     INFO - Renderer: Intel Iris OpenGL Engine
14:23:22     INFO - FBO Texture Target: TEXTURE_2D
14:23:22     INFO - Console message: [JavaScript Error: "NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIWebNavigation.loadURIWithOptions]" {file: "chrome://global/content/browser-child.js" line: 354}]
14:23:22     INFO - Buffered messages logged at 14:21:51
14:23:22     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 1
14:23:22     INFO - Buffered messages finished
14:23:22     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_tabs_executeScript_good.js | Test timed out - 
14:23:22     INFO - Not taking screenshot here: see the one that was previously logged
14:23:22     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_tabs_executeScript_good.js | Extension left running at test shutdown - 
14:23:22     INFO - Stack trace:
14:23:22     INFO -     chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:ExtensionTestUtils.loadExtension/<:109
14:23:22     INFO -     chrome://mochikit/content/browser-test.js:Tester.prototype.nextTest<:409
14:23:22     INFO -     timeoutFn@chrome://mochikit/content/browser-test.js:891:9
14:23:22     INFO -     setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:676:12
14:23:22     INFO -     timeoutFn@chrome://mochikit/content/browser-test.js:869:13
14:23:22     INFO -     setTimeout handler*Tester_execTest@chrome://mochikit/content/browser-test.js:853:9
14:23:22     INFO -     Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:687:7
14:23:22     INFO -     SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59

Comment 7

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8898934 [details]
Bug 1391720 remove _blank support for background pages,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/170302/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c072924e820
remove _blank support for background pages, r=kmag

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/4c072924e820