1391759 - [Photon] Page action temp panel (e.g., the Pocket panel) should have rounded corners (not square ones) on OS X

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Drew Willcoxon :adw]

I saw bug 1374315 and realized that the temp panel for page actions (like Pocket's panel) has square corners too.  Simply setting photon=true on the panel fixes it.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1391759 - [Photon] Page action temp panel (e.g., the Pocket panel) should have rounded corners (not square ones) on OS X.

Review commit: https://reviewboard.mozilla.org/r/170308/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/170308/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8898957 [details]
Bug 1391759 - [Photon] Page action temp panel (e.g., the Pocket panel) should have rounded corners (not square ones) on OS X.

https://reviewboard.mozilla.org/r/170308/#review175538

Thanks!

Comment 3

[Drew Willcoxon :adw]

Thanks for the quick review.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38a3d878a75f
[Photon] Page action temp panel (e.g., the Pocket panel) should have rounded corners (not square ones) on OS X. r=Gijs

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/38a3d878a75f

Comment 6

[u554753]

Verified on Mac OS X 10.11 using Nightly 58.0a1 (64-bit) as of today's date.

Comment 7

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I have reproduced this issue using Firefox  57.0a1 (2017.08.18) on Mac OS X 10.11.
I can confirm this issue is fixed, I verified using Firefox 57.0b6 on Mac OS X 10.11.