Closed Bug 1391779 Opened 4 years ago Closed 4 years ago

2.04 - 5.77% tp5o Main_RSS / tp5o Private Bytes / tp5o_webext Main_RSS / tp5o_webext Private Bytes / tp5o_webext responsiveness (linux64) regression on push 5c55ebeb214b8109d158eb17de7f24852e6d0a63 (Thu Aug 17 2017)

Categories

(Firefox :: New Tab Page, defect)

53 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- fixed

People

(Reporter: jmaher, Assigned: Mardak)

References

Details

(Keywords: perf, regression, talos-regression)

Talos has detected a Firefox performance regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=5c55ebeb214b8109d158eb17de7f24852e6d0a63

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

  6%  tp5o_webext responsiveness linux64 opt e10s     5.38 -> 5.69
  3%  tp5o_webext Private Bytes linux64 opt e10s      971,567,130.51 -> 1,004,203,109.60
  3%  tp5o Private Bytes linux64 opt e10s             966,200,608.42 -> 997,052,776.30
  3%  tp5o Private Bytes linux64 pgo e10s             972,127,673.20 -> 1,002,404,837.59
  2%  tp5o Main_RSS linux64 pgo e10s                  175,116,371.46 -> 179,118,435.78
  2%  tp5o_webext Main_RSS linux64 opt e10s           185,063,848.93 -> 188,842,820.21


You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=8866

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the Talos jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://wiki.mozilla.org/Buildbot/Talos/Tests

For information on reproducing and debugging the regression, either on try or locally, see: https://wiki.mozilla.org/Buildbot/Talos/Running

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/Buildbot/Talos/RegressionBugsHandling
:k88hudson, I see you are the patch author- we are showing memory regressions on linux as well as a responsiveness regression (6% sounds big, but the raw numbers might make it less daunting).  Can you look into this regression and determine if this is expected, something we can reduce, or ideally something we can fix!
Flags: needinfo?(khudson)
Component: Untriaged → Add-ons Manager
Product: Firefox → Toolkit
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #0)
> https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=5c55ebeb214b8109d158eb17de7f24852e6d0a63
jmaher, that push seems to point to rhelmer's bug 1389160 ?

Although perfherder's pushlog link has a few other commits..?
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=859e657f26dc808e922938350ffa7e6c4fc67583&tochange=5c55ebeb214b8109d158eb17de7f24852e6d0a63
Blocks: 1389160
Flags: needinfo?(rhelmer)
Flags: needinfo?(jmaher)
the alert was for :rhelmer's push, but the test wasn't run for a few pushes (which is very common).  Before filing the bug, I backfilled the test to ensure we had coverage on all the pushes with retriggers and it showed up on the activity stream push:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0c92ba4c69428e9db95b1d2cb0c72032a46a80ca&tochange=a98e20c4664b65e4945a15c2b4330ec3fb2f01b6

you can clearly see it in the graph:
https://treeherder.mozilla.org/perf.html#/graphs?series=autoland,1309557,1,1&series=mozilla-inbound,1316782,1,1&zoom=1502988654331.4011,1503021471951.4382,172979775.41805652,182732584.40682057&selected=%5Bautoland,3e7f4391cabfa0dd7253beed294f8e91e453def2,241823,313114149,1%5D

Sorry for the confusion.
Flags: needinfo?(rhelmer)
Flags: needinfo?(jmaher)
Component: Add-ons Manager → Activity Streams: Newtab
Product: Toolkit → Firefox
Flags: needinfo?(kmaglione+bmo)
Priority: -- → P1
Sorry, this got caught up in another triage.
Flags: needinfo?(kmaglione+bmo)
Priority: P1 → --
This seems to have been mostly fixed with the most recent activity stream export from bug 1392384 comment 5?
yes, most of them are back to original values or close, in a few cases bug 1393739 caused changes on the same tests and we accepted that.
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(khudson)
Resolution: --- → FIXED
Assignee: nobody → edilee
Target Milestone: --- → Firefox 57
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.