1391947 - Make "View Bookmarks Sidebar" item active in "Bookmarks" button menu and add its proper new Photon item icon

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: screenshot.png

"View Bookmarks Sidebar" item icon is missing in "Bookmarks" button menu

The proper icon for "View Bookmarks Sidebar" item is shown in:
- "Hamburger" button menu => "Library" item menu => "Bookmarks" item menu => "Bookmarking tools" item menu
- "Library" button menu => "Bookmarks" item menu => "Bookmarking tools" item menu

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: screenshot2.png

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: screenshot3.png

Comment 3

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Also this "View Bookmarks Sidebar", should be active, like the same items located in:
- "Hamburger" button menu => "Library" item menu => "Bookmarks" item menu => "Bookmarking tools" item menu
- "Library" button menu => "Bookmarks" item menu => "Bookmarking tools" item menu,
so there should be "View Bookmarks Toolbar" and "Hide Bookmarks Sidebar", instead tick option.

Comment 4

[Mike de Boer [:mikedeboer]]

Virtual, I'd like to get to morph this bug into something actionable; what is the end result that you'd ideally see?

That the Bookmarks Menu (which is not in the navbar by default anymore, but can customize back) adopt the Photon design as shown in the new Bookmarks subview inside the Library?
What's the exact difference between this bug and bug 1391948?

Comment 5

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I would like to make "View Bookmarks Sidebar" active item, not "half-passive" like it's now,
so it won't be having this tick/check mark for:
- Bookmarks Sidebar enabled/visible = "View Bookmarks Sidebar" ticked/checked
- Bookmarks Sidebar disabled/hidden = "View Bookmarks Sidebar" not ticked/check,
but instead, it will be be consistent with same "View Bookmarks Sidebar" active item, which is located in "Bookmarking tools" menu,
it will be also "active", so it will
- Bookmarks Sidebar enabled/visible = "View Bookmarks Sidebar"
- Bookmarks Sidebar disabled/hidden = "Hide Bookmarks Sidebar"
and also add its proper new Photon item icon, not nothing or tick/check mark like it's now.

Similar issue is in bug #1391948, but different menu item, here "Bookmarks Sidebar", there "Bookmarks Toolbar".

I hope it's now clear, if not, ni me again.

Comment 6

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: is.png

Comment 7

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: should be.png