Closed Bug 1391947 Opened 3 years ago Closed 2 years ago

Make "View Bookmarks Sidebar" item active in "Bookmarks" button menu and add its proper new Photon item icon

Categories

(Firefox :: Bookmarks & History, defect, P1)

57 Branch
x86_64
Windows 7
defect

Tracking

()

VERIFIED FIXED
Firefox 61
Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- wontfix
firefox60 --- wontfix
firefox61 --- verified

People

(Reporter: Virtual, Assigned: Paolo)

References

(Blocks 1 open bug)

Details

(Keywords: nightly-community, ux-consistency, Whiteboard: [reserve-photon-structure] [fixed by patch from bug #1391948])

Attachments

(5 files)

Attached image screenshot.png
"View Bookmarks Sidebar" item icon is missing in "Bookmarks" button menu

The proper icon for "View Bookmarks Sidebar" item is shown in:
- "Hamburger" button menu => "Library" item menu => "Bookmarks" item menu => "Bookmarking tools" item menu
- "Library" button menu => "Bookmarks" item menu => "Bookmarking tools" item menu
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant
Also this "View Bookmarks Sidebar", should be active, like the same items located in:
- "Hamburger" button menu => "Library" item menu => "Bookmarks" item menu => "Bookmarking tools" item menu
- "Library" button menu => "Bookmarks" item menu => "Bookmarking tools" item menu,
so there should be "View Bookmarks Toolbar" and "Hide Bookmarks Sidebar", instead tick option.
Summary: "View Bookmarks Sidebar" item icon is missing in "Bookmarks" button menu → Make "View Bookmarks Sidebar" item active in "Bookmarks" button menu and add its proper new Photon item icon
Whiteboard: [photon] [triage] → [photon-visual] [photon-structure] [triage]
Flags: qe-verify+
Whiteboard: [photon-visual] [photon-structure] [triage] → [photon-structure] [triage]
Priority: -- → P4
Whiteboard: [photon-structure] [triage] → [reserve-photon-structure]
Virtual, I'd like to get to morph this bug into something actionable; what is the end result that you'd ideally see?

That the Bookmarks Menu (which is not in the navbar by default anymore, but can customize back) adopt the Photon design as shown in the new Bookmarks subview inside the Library?
What's the exact difference between this bug and bug 1391948?
Flags: needinfo?(Virtual)
I would like to make "View Bookmarks Sidebar" active item, not "half-passive" like it's now,
so it won't be having this tick/check mark for:
- Bookmarks Sidebar enabled/visible = "View Bookmarks Sidebar" ticked/checked
- Bookmarks Sidebar disabled/hidden = "View Bookmarks Sidebar" not ticked/check,
but instead, it will be be consistent with same "View Bookmarks Sidebar" active item, which is located in "Bookmarking tools" menu,
it will be also "active", so it will
- Bookmarks Sidebar enabled/visible = "View Bookmarks Sidebar"
- Bookmarks Sidebar disabled/hidden = "Hide Bookmarks Sidebar"
and also add its proper new Photon item icon, not nothing or tick/check mark like it's now.

Similar issue is in bug #1391948, but different menu item, here "Bookmarks Sidebar", there "Bookmarks Toolbar".

I hope it's now clear, if not, ni me again.
Flags: needinfo?(Virtual)
Blocks: 1352110
No longer blocks: photon-structure
Priority: P4 → P5
Assignee: nobody → paolo.mozmail
Status: NEW → RESOLVED
Closed: 2 years ago
Depends on: 1391948
Resolution: --- → FIXED
See Also: 1391948
Whiteboard: [reserve-photon-structure] → [reserve-photon-structure] [fixed by patch from bug #1391948]
Priority: P5 → P1
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.