Closed
Bug 1391952
Opened 7 years ago
Closed 7 years ago
Introduce eslint rule to enforce camelcasing
Categories
(Remote Protocol :: Marionette, enhancement)
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
Details
Attachments
(3 files)
JavaScript code in testing/marionette predominantly uses camel-case for properties and variable names. To ensure consistency in this, we should add an eslint rule for it. There are some exceptions where we use snake case for output sent across the wire. We can disable the lint rule on an individual basis for these cases.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8899122 [details] Bug 1391952 - Introduce camel case lint rule. https://reviewboard.mozilla.org/r/170428/#review175770 ::: commit-message-4f448:9 (Diff revision 1) > +camel casing in naming properties and variables. To enforce consistency > +with this practice, this patch adds an eslint rule to enforce camel case. > + > +There are a few exceptions where we use snake case in response output. > +We can disable the lint rule on an individual basis in this handful > +of cases. Please put this changeset last in this series to not cause lint failures.
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8899123 [details] Bug 1391952 - Disable camel case lint for input and output. https://reviewboard.mozilla.org/r/170430/#review175812
Attachment #8899123 -
Flags: review?(dburns) → review+
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8899124 [details] Bug 1391952 - Lint testing/marionette. https://reviewboard.mozilla.org/r/170432/#review175816
Attachment #8899124 -
Flags: review?(dburns) → review+
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8899122 [details] Bug 1391952 - Introduce camel case lint rule. https://reviewboard.mozilla.org/r/170428/#review175818
Attachment #8899122 -
Flags: review?(dburns) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 11•7 years ago
|
||
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/83654c55045b Lint testing/marionette. r=automatedtester https://hg.mozilla.org/integration/autoland/rev/213d621c2126 Disable camel case lint for input and output. r=automatedtester https://hg.mozilla.org/integration/autoland/rev/e0c0a84e0dfd Introduce camel case lint rule. r=automatedtester
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/83654c55045b https://hg.mozilla.org/mozilla-central/rev/213d621c2126 https://hg.mozilla.org/mozilla-central/rev/e0c0a84e0dfd
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•