1391960 - Canvas layers-free support regressed non-webrender canvas

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Kan-Ru Chen [:kanru] (UTC+9)]

The summary is kind of vague but I couldn't find a better way to express it.

While testing the dashboard at https://kanru.github.io/hasal-dashboard/
I found sometimes the tooltip for charts near the end couldn't show up.

mozregression find the first bad push is https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=a5dd38359df4811909ea0ec1da7b9cd9bfcd9245&tochange=c4e2c3d4f17c5486d2b3b2698dd4ea7e1b036790

The chart and the tooltips are drawn on a canvas so I think the push did break something. WebRender mode was not enabled while testing.

Comment 1

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

:kanru, do you have more specific STR? I just opened the website but the tooltip looks good. Or can you attach some screenshots?

Comment 2

[Kan-Ru Chen [:kanru] (UTC+9)]

STR:

1. open the website and wait for the result
2. hover the mouse on one bar
   you should see a tooltip
3. scroll to the bottom
4. hover the mouse on one bar
   expected: shows tooltip
   actually: no

Comment 3

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: First tooltip shows correctly screenshot.png

Comment 4

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: Scroll to bottom missing tooltip screenshot.png

Comment 5

[Kan-Ru Chen [:kanru] (UTC+9)]

The bottom canvas does not update until scrolled off-screen or after viewport size change.

Comment 6

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

I can reproduce it in ubuntu with layers acceleration off.

Comment 7

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Bug 1391960 - Call FireDidTransactionCallback when exiting ReadbackSurface.

If we bailed out in ReadbackSurface function, we didn't call
FireDidTransactionCallback properly. Added ScopedFireTransactionCallback
struct to do this right.

Review commit: https://reviewboard.mozilla.org/r/170610/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/170610/

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8899373 [details]
Bug 1391960 - Call FireDidTransactionCallback when exiting ReadbackSurface.

Nical's probably a better reviewer for this than me.

Comment 9

[Nicolas Silva [:nical]]

Comment on attachment 8899373 [details]
Bug 1391960 - Call FireDidTransactionCallback when exiting ReadbackSurface.

https://reviewboard.mozilla.org/r/170610/#review175926

Comment 10

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a69e8dd6c6d0cd7d84a87eb50811e6072ae7474

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0142c177ac0
Call FireDidTransactionCallback when exiting ReadbackSurface. r=nical

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b0142c177ac0