Canvas layers-free support regressed non-webrender canvas

RESOLVED FIXED in Firefox 57

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: kanru, Assigned: mtseng)

Tracking

({regression})

Trunk
mozilla57
regression
Points:
---

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox55 unaffected, firefox56 unaffected, firefox57 fixed)

Details

(URL)

Attachments

(3 attachments)

(Reporter)

Description

2 years ago
The summary is kind of vague but I couldn't find a better way to express it.

While testing the dashboard at https://kanru.github.io/hasal-dashboard/
I found sometimes the tooltip for charts near the end couldn't show up.

mozregression find the first bad push is https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=a5dd38359df4811909ea0ec1da7b9cd9bfcd9245&tochange=c4e2c3d4f17c5486d2b3b2698dd4ea7e1b036790

The chart and the tooltips are drawn on a canvas so I think the push did break something. WebRender mode was not enabled while testing.
Flags: needinfo?(mtseng)
:kanru, do you have more specific STR? I just opened the website but the tooltip looks good. Or can you attach some screenshots?
Flags: needinfo?(mtseng) → needinfo?(kchen)
(Reporter)

Comment 2

2 years ago
STR:

1. open the website and wait for the result
2. hover the mouse on one bar
   you should see a tooltip
3. scroll to the bottom
4. hover the mouse on one bar
   expected: shows tooltip
   actually: no
Flags: needinfo?(kchen)
(Reporter)

Comment 3

2 years ago
Created attachment 8899317 [details]
First tooltip shows correctly screenshot.png
(Reporter)

Comment 4

2 years ago
Created attachment 8899318 [details]
Scroll to bottom missing tooltip screenshot.png
(Reporter)

Comment 5

2 years ago
The bottom canvas does not update until scrolled off-screen or after viewport size change.
I can reproduce it in ubuntu with layers acceleration off.
Assignee: nobody → mtseng
Comment hidden (mozreview-request)
Comment on attachment 8899373 [details]
Bug 1391960 - Call FireDidTransactionCallback when exiting ReadbackSurface.

Nical's probably a better reviewer for this than me.
Attachment #8899373 - Flags: review?(jmuizelaar) → review?(nical.bugzilla)

Comment 9

2 years ago
mozreview-review
Comment on attachment 8899373 [details]
Bug 1391960 - Call FireDidTransactionCallback when exiting ReadbackSurface.

https://reviewboard.mozilla.org/r/170610/#review175926
Attachment #8899373 - Flags: review?(nical.bugzilla) → review+

Comment 11

2 years ago
Pushed by mtseng@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0142c177ac0
Call FireDidTransactionCallback when exiting ReadbackSurface. r=nical

Comment 12

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b0142c177ac0
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
status-firefox55: --- → unaffected
status-firefox56: --- → unaffected
status-firefox-esr52: --- → unaffected
You need to log in before you can comment on or make changes to this bug.