Checked Quick Filter Bar button uses not the LW-Theme text color.

RESOLVED FIXED in Thunderbird 57.0

Status

Thunderbird
Theme
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

Trunk
Thunderbird 57.0
All
Windows

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

10 months ago
Created attachment 8899273 [details]
screenshot.png

With dark LW-Themes the QFB-button uses still black as text color. This comes because the color is in toolkit defined when a button is checked.
(Assignee)

Comment 1

10 months ago
Created attachment 8899274 [details] [diff] [review]
checkedColor.patch

Set inherit when checked="true" fixes the issue.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8899274 - Flags: review?(jorgk)

Comment 2

10 months ago
Comment on attachment 8899274 [details] [diff] [review]
checkedColor.patch

I don't have a LW theme and I trust you with one line.
Attachment #8899274 - Flags: review?(jorgk) → review+
(Assignee)

Updated

10 months ago
Keywords: checkin-needed

Comment 3

10 months ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e6d674f8df98
Inherit the color for checked toolbarbuttons. r=jorgk
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

10 months ago
Target Milestone: --- → Thunderbird 57.0
You need to log in before you can comment on or make changes to this bug.