1392163 - Remove ImageBridgeChild::DispatchReleaseTextureClient()

Status: RESOLVED FIXED

(Core :: Graphics: Layers, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

ImageBridgeChild::DispatchReleaseTextureClient() seems not necessary any more.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Remove ImageBridgeChild::DispatchReleaseTextureClient()

Comment 2

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2533b90dc0cb546c7bbb8bd769a429c08b2bb57a

Comment 3

[Nicolas Silva [:nical]]

I am missing some context, what made it unnecessary?

Comment 4

[Sotaro Ikeda [:sotaro]]

ImageBridgeChild::DispatchReleaseTextureClient() is used only by SharedPlanarYCbCrImage::~SharedPlanarYCbCrImage() and SharedRGBImage::~SharedRGBImage(). The role was to release refcount of TextureClient on ImageBridgeChild thread. It was originally added by bug 886219. At that time, TextureClient have to be released on Compositor thread to avoild memory leak. But TextureClient does not have such limitation anymore.

Further SharedPlanarYCbCrImage::~SharedPlanarYCbCrImage() and SharedRGBImage::~SharedRGBImage() do not work as expected originally by Bug 1144906. The change was like the following. mTextureClient was set to null after ImageBridgeChild::DispatchReleaseTextureClient(). There could be a case that ReleaseTextureClient on ImageBridge could happen before clearing mTextureClient.

> -    ImageBridgeChild::DispatchReleaseTextureClient(mTextureClient.forget().take());
> +    ADDREF_MANUALLY(mTextureClient);
> +    ImageBridgeChild::DispatchReleaseTextureClient(mTextureClient);
> +    mTextureClient = nullptr;

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/47027aa05bac
Remove ImageBridgeChild::DispatchReleaseTextureClient() r=nical

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/47027aa05bac