Closed Bug 1392175 Opened 7 years ago Closed 7 years ago

Change the loading path of CDM host verification file for XUL and firefox executable on Mac

Categories

(Core :: Audio/Video: GMP, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox56 --- fixed
firefox57 --- fixed

People

(Reporter: JamesCheng, Assigned: JamesCheng)

References

Details

Attachments

(1 file)

Bug 1390725 only changes the loading path of plugin-container.sig,

By observation, the reset of sig files are also located in something like

/Applications/FirefoxNightly.app/Contents/Resources/*.sig
Record the file location from my Nightly.

/Applications/FirefoxNightly.app/Contents/MacOS/firefox
/Applications/FirefoxNightly.app/Contents/Resources/firefox.sig

/Applications/FirefoxNightly.app/Contents/MacOS/XUL
/Applications/FirefoxNightly.app/Contents/Resources/XUL.sig
Comment on attachment 8899348 [details]
Bug 1392175 - Change the loading path of CDM host verification file for XUL and firefox executable x on Mac.

https://reviewboard.mozilla.org/r/170576/#review175778
Attachment #8899348 - Flags: review?(cpearce) → review+
Pushed by jacheng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e9adfa195077
Change the loading path of CDM host verification file for XUL and firefox executable x on Mac. r=cpearce
Comment on attachment 8899348 [details]
Bug 1392175 - Change the loading path of CDM host verification file for XUL and firefox executable x on Mac.

Approval Request Comment
[Feature/Bug causing the regression]:NO
[User impact if declined]: user could not play DRM content. When we update new CDM.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]:
Please follow this order for uplifting
1. Bug 1390453
2. Bug 1390739
3. Bug 1390725
4. This Bug 1392175 
[Is the change risky?]:No
[Why is the change risky/not risky?]:The change did not effect on the current CDM.  
[String changes made/needed]: No


I've import those patches locally and haven't met any conflict.
Attachment #8899348 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/e9adfa195077
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment on attachment 8899348 [details]
Bug 1392175 - Change the loading path of CDM host verification file for XUL and firefox executable x on Mac.

#4 of several patches to be uplifted in order, for CDM changes in 56 beta 6.
Attachment #8899348 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(In reply to James Cheng[:JamesCheng] from comment #5)
> [Is this code covered by automated tests?]: No
> [Has the fix been verified in Nightly?]: Yes
> [Needs manual test from QE? If yes, steps to reproduce]: No

Setting qe-verify- based on James's assessment on manual testing needs.
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.