Closed
Bug 1392201
Opened 7 years ago
Closed 7 years ago
Label nsThreadShutdownAckEvent
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: bevis, Assigned: bevis)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.83 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
This runnable shows up in the latest top unlabeled runnable list: https://gist.github.com/bevis-tseng/d8a918cb53112a82357c872ce15ee790 We could label this one with SystemGroup since it touches nothing related to a web content.
|
Assignee | |
Comment 1•7 years ago
|
||
Choose SystemGroup to dispatch if nsThreadShutdownContext::mJoiningThread is actually the main thread. Wait for treeherder result to verify this fix: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5febbaaa04f76f29da74fa359bea8e54d027c08
|
|
Assignee | |
Comment 2•7 years ago
|
||
The previous patch is incorrect. Upload the right one for reference.
Attachment #8899383 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•7 years ago
|
||
Comment on attachment 8899391 [details] [diff] [review] (v1) Patch: Label nsThreadShutdownAckEvent. Label this runnable using SystemGroup if the main thread is joining this shutdown procedure.
Attachment #8899391 -
Flags: review?(nfroyd)
|
||
Updated•7 years ago
|
Attachment #8899391 -
Flags: review?(nfroyd) → review+
Pushed by btseng@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fe7d953913e0 Label nsThreadShutdownAckEvent. r=froydnj
|
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fe7d953913e0
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
||
Updated•6 years ago
|
Assignee: nobody → bevistseng
You need to log in
before you can comment on or make changes to this bug.
Description
•