Open Bug 1392231 Opened 2 years ago Updated Last year

Further optimizations for data URIs

Categories

(Core :: Networking, enhancement, P3)

enhancement

Tracking

()

People

(Reporter: valentin, Unassigned)

References

Details

(Whiteboard: [necko-triaged])

(In reply to Eric Rahm [:erahm] (please no mozreview requests) from bug 1369317 comment #28)
> (In reply to Valentin Gosu [:valentin] from bug 1369317 comment #23)
> > This fixes about half of the issues mentioned in comment 11. 
> > 
> > This would be what is left:
> > Base64Decode -
> > https://searchfox.org/mozilla-central/source/netwerk/protocol/data/nsDataChannel.cpp#75
> > 
> > NS_UnescapeURL -
> > https://searchfox.org/mozilla-central/rev/1a0d9545b9805f50a70de703a3c04fc0d22e3839/netwerk/protocol/data/nsDataChannel.cpp#39.
> > This is tricky, but maybe we can find a way to cache it, or not do it at all.
> >
> > StripWhitespace -
> > https://searchfox.org/mozilla-central/rev/1a0d9545b9805f50a70de703a3c04fc0d22e3839/netwerk/protocol/data/nsDataChannel.cpp#45
> > As we do this just before SetSpec, we can probably make SetSpec deal with
> > whitespace as well, in just one pass.
> 
> Just a reminder most of this is addressed in bug 1333899. We could probably
> pull those over here and just leave the string stream change in the other
> bug.
(In reply to Valentin Gosu [:valentin] from comment #0)
> (In reply to Eric Rahm [:erahm] (please no mozreview requests) from bug
> 1369317 comment #28)
> > (In reply to Valentin Gosu [:valentin] from bug 1369317 comment #23)
> > > This fixes about half of the issues mentioned in comment 11. 
> > > 
> > > This would be what is left:
> > > Base64Decode -
> > > https://searchfox.org/mozilla-central/source/netwerk/protocol/data/nsDataChannel.cpp#75

I have some patches in-progress to address this; I think I can create a streaming base64 decoder and pass that back out as the input stream.
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: -- → P2
Depends on: 1435899
(In reply to Nathan Froyd [:froydnj] from comment #1)
> > > > This would be what is left:
> > > > Base64Decode -
> > > > https://searchfox.org/mozilla-central/source/netwerk/protocol/data/nsDataChannel.cpp#75
> 
> I have some patches in-progress to address this; I think I can create a
> streaming base64 decoder and pass that back out as the input stream.

Nathan, do we have a bug for this?
Flags: needinfo?(nfroyd)
Priority: P2 → P3
Whiteboard: [necko-next] → [necko-triaged]
(In reply to Valentin Gosu [:valentin] from comment #3)
> (In reply to Nathan Froyd [:froydnj] from comment #1)
> > > > > This would be what is left:
> > > > > Base64Decode -
> > > > > https://searchfox.org/mozilla-central/source/netwerk/protocol/data/nsDataChannel.cpp#75
> > 
> > I have some patches in-progress to address this; I think I can create a
> > streaming base64 decoder and pass that back out as the input stream.
> 
> Nathan, do we have a bug for this?

This is now bug 1512973.  I'm not sure what happened to my patches, though. :(
Flags: needinfo?(nfroyd)
You need to log in before you can comment on or make changes to this bug.