1392232 - [compare-locales] refactor compare_locales.paths.ProjectFiles._files to take matcher instead of matcher.prefix

Status: RESOLVED FIXED

(Localization Infrastructure and Tools :: compare-locales, defect)

Description

[Axel Hecht [:Pike]]

Right now, the ProjectFiles._files method takes a path, which is a tad unfortunate when trying to subclass it for version control systems.

On filesystems, this is nice as you can iterate over the dir. But on vcs, you get all paths at once, and one's actually much more interested in a direct filter.

Comment 1

[Axel Hecht [:Pike]]

Attachment: bug 1392232, refactor ProjectFiles._filter from path to Matcher,

When subclassing _filter, you may need all the information in the
Matcher object, not just the base path.
Thus, pass in the matcher instead of matcher.prefix, and move the
.match() piece into ._filter, too.

Review commit: https://reviewboard.mozilla.org/r/170722/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/170722/

Comment 2

[Francesco Lodolo [:flod]]

Comment on attachment 8899442 [details]
bug 1392232, refactor ProjectFiles._filter from path to Matcher,

https://reviewboard.mozilla.org/r/170722/#review175974

Code makes sense and it still works ;-)

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 8899442 [details]
bug 1392232, refactor ProjectFiles._filter from path to Matcher,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/170722/diff/1-2/

Comment 4

[Axel Hecht [:Pike]]

https://hg.mozilla.org/l10n/compare-locales/rev/3cf15026dd4db3d3ce4baca0b81acc4444c1a4b8, thanks, FIXED.