[compare-locales] refactor compare_locales.paths.ProjectFiles._files to take matcher instead of matcher.prefix

RESOLVED FIXED

Status

Localization Infrastructure and Tools
compare-locales
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: Pike, Assigned: Pike)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

8 months ago
Right now, the ProjectFiles._files method takes a path, which is a tad unfortunate when trying to subclass it for version control systems.

On filesystems, this is nice as you can iterate over the dir. But on vcs, you get all paths at once, and one's actually much more interested in a direct filter.
Comment hidden (mozreview-request)

Comment 2

8 months ago
mozreview-review
Comment on attachment 8899442 [details]
bug 1392232, refactor ProjectFiles._filter from path to Matcher,

https://reviewboard.mozilla.org/r/170722/#review175974

Code makes sense and it still works ;-)
Attachment #8899442 - Flags: review?(francesco.lodolo) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 4

8 months ago
https://hg.mozilla.org/l10n/compare-locales/rev/3cf15026dd4db3d3ce4baca0b81acc4444c1a4b8, thanks, FIXED.
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.