1392237 - Onboarding banner on about:home in nightly is appearing over the buttons

Status: RESOLVED WONTFIX

(Firefox :: General, defect)

Description

[Clément Lefèvre]

Attachment: Screenshot from 2017-08-21 14-17-35.png

There is currently a banner with new things in Nightly appearing on about:newtab and about:home.

This banner does appear every single time (ie. more than on every daily update) and is covering the buttons, especially the one to restore session on about:home.

See joined screenshot for that.

This banner should either be elsewhere, or not shown every single time, making it annoying for the user

Comment 1

[:Gijs (back August 25; he/him)]

Several things going on here...

1) my understanding is you shouldn't be seeing this at all - it's supposed to only be shown for new users. Is this a new profile? Do you also see this on existing profiles?

2) the overlap was wontfixed in bug 1377347, but it seems to be based on the assumption that we will no longer ship about:home as the homepage. I don't know if that's still planned for 57, but it hasn't happened yet.

3) there are scrollbars in the text for the tour. This seems like a bug.

4) the bubble at the top left is in English, but the other strings are in French. Is this a build with a separately-installed language pack or something, or is the bubble text hardcoded somewhere?

Needinfo -> Fischer + Verdi for (2), (3) and (4)

Comment 2

[Clément Lefèvre]

So, to answer your questions:

1/ Yes I'm seeing it every time, on my usual profile, on at least two computers, I can try a third this evening.

3/ I reported this in bug 1392239

4/ It's the builds from Mozilla for all of my platforms (Linux, OS X, Windows), and it's always there, then no language pack. I guess it's not translated yet, but I didn't checked it though.

Comment 3

[Fischer [:Fischer]]

(In reply to :Gijs from comment #1)
> Several things going on here...
> 
> 1) my understanding is you shouldn't be seeing this at all - it's supposed
> to only be shown for new users. Is this a new profile? Do you also see this
> on existing profiles?
> 
Looks like Clément is seeing the onboarding tour for the update users.

> 2) the overlap was wontfixed in bug 1377347, but it seems to be based on the
> assumption that we will no longer ship about:home as the homepage. I don't
> know if that's still planned for 57, but it hasn't happened yet.
> 
Until the last time of checking with the AS team (bug 1381716 comment 2), about:home will be the AS page.

> 3) there are scrollbars in the text for the tour. This seems like a bug.
> 
The bug 1388813 is handling this.

> 4) the bubble at the top left is in English, but the other strings are in
> French. Is this a build with a separately-installed language pack or
> something, or is the bubble text hardcoded somewhere?
> 
The speech bubble in the screenshot is for the update user, which got added in the bug 1380963 around a month ago, not sure if got translated (although it is for FF57).

Comment 4

[Fischer [:Fischer]]

(In reply to Clément Lefèvre from comment #2)
> So, to answer your questions:
> 
> 1/ Yes I'm seeing it every time, on my usual profile, on at least two
> computers, I can try a third this evening.
> 
Hi Clément,
Is you FF the FF57 nightly?
If yes, this is expected because we added the tours for users updating to FF57 from the old FF.

Comment 5

[:Gijs (back August 25; he/him)]

(In reply to Fischer [:Fischer] from comment #3)
> > 2) the overlap was wontfixed in bug 1377347, but it seems to be based on the
> > assumption that we will no longer ship about:home as the homepage. I don't
> > know if that's still planned for 57, but it hasn't happened yet.
> > 
> Until the last time of checking with the AS team (bug 1381716 comment 2),
> about:home will be the AS page.

My point was that it's not certain if we'll do this for 57. The comment you link to was made a month ago, and it does not say that the transition of about:home to AS is making 57, just that it will happen eventually. So the comment doesn't address my point.

Comment 6

[:Gijs (back August 25; he/him)]

(In reply to Fischer [:Fischer] from comment #4)
> (In reply to Clément Lefèvre from comment #2)
> > So, to answer your questions:
> > 
> > 1/ Yes I'm seeing it every time, on my usual profile, on at least two
> > computers, I can try a third this evening.
> > 
> Hi Clément,
> Is you FF the FF57 nightly?
> If yes, this is expected because we added the tours for users updating to
> FF57 from the old FF.

That show up every startup and never go away, per comment #0? That doesn't seem right...

Comment 7

[Fischer [:Fischer]]

Hi Flod,

Please see the screenshot[1]. 
You will see the notification bar in the bottom of the page is in French. But the top-left fox icon's speech bubble is in English.
The speech bubble strings in the screenshot were added in the bug 1380963 around a month ago. Just to check with you if this is correct that the speech bubble strings is still in English and will be translated later. Thank you

[1] attachment 8899435 [details]: Screenshot from 2017-08-21 14-17-35.png

Comment 8

[Fischer [:Fischer]]

(In reply to :Gijs from comment #5)
> (In reply to Fischer [:Fischer] from comment #3)
> > > 2) the overlap was wontfixed in bug 1377347, but it seems to be based on the
> > > assumption that we will no longer ship about:home as the homepage. I don't
> > > know if that's still planned for 57, but it hasn't happened yet.
> > > 
> > Until the last time of checking with the AS team (bug 1381716 comment 2),
> > about:home will be the AS page.
> 
> My point was that it's not certain if we'll do this for 57. The comment you
> link to was made a month ago, and it does not say that the transition of
> about:home to AS is making 57, just that it will happen eventually. So the
> comment doesn't address my point.
Right, that should be a concern. Will check out the status with the AS team again.

(In reply to :Gijs from comment #6)
> (In reply to Fischer [:Fischer] from comment #4)
> > (In reply to Clément Lefèvre from comment #2)
> > > So, to answer your questions:
> > > 
> > > 1/ Yes I'm seeing it every time, on my usual profile, on at least two
> > > computers, I can try a third this evening.
> > > 
> > Hi Clément,
> > Is you FF the FF57 nightly?
> > If yes, this is expected because we added the tours for users updating to
> > FF57 from the old FF.
> 
> That show up every startup and never go away, per comment #0? That doesn't seem right...
All right, then this probably should let verdi comment here.
For each tour, it got at most 16 times of being prompted with notificatoin if user didn't interact with it. Once user interacts (click the close/action button) with it, that tour wouldn't be prompted any more. Just that there are 6 tours so at minimum there would be 6 times of seeing tour notifications.

Comment 9

[Francesco Lodolo [:flod]]

(In reply to Fischer [:Fischer] from comment #7)
> The speech bubble strings in the screenshot were added in the bug 1380963
> around a month ago. Just to check with you if this is correct that the
> speech bubble strings is still in English and will be translated later.

Nope, the speech bubble was modified 5 days ago in bug 1389541, and it's simply not been localized yet
https://hg.mozilla.org/mozilla-central/rev/5ec2e0d3e78c

Comment 10

[:Gijs (back August 25; he/him)]

(In reply to Fischer [:Fischer] from comment #8)
> For each tour, it got at most 16 times of being prompted with notificatoin
> if user didn't interact with it. Once user interacts (click the close/action
> button) with it, that tour wouldn't be prompted any more. Just that there
> are 6 tours so at minimum there would be 6 times of seeing tour
> notifications.

Sorry, so the user has to click the [x] 6 * 16 = 96 times?

Comment 11

[Clément Lefèvre]

(In reply to Fischer [:Fischer] from comment #4)
> (In reply to Clément Lefèvre from comment #2)
> > So, to answer your questions:
> > 
> > 1/ Yes I'm seeing it every time, on my usual profile, on at least two
> > computers, I can try a third this evening.
> > 
> Hi Clément,
> Is you FF the FF57 nightly?
> If yes, this is expected because we added the tours for users updating to
> FF57 from the old FF.

Yes, and this has always been a nightly. However on the current computer I'm writing from and following the update I had two hours ago, I don't have the banner anymore. I've got to test it on my other computers later, this evening.

(In reply to Fischer [:Fischer] from comment #8)
> (In reply to :Gijs from comment #5)
> > (In reply to Fischer [:Fischer] from comment #3)
> > > > 2) the overlap was wontfixed in bug 1377347, but it seems to be based on the
> > > > assumption that we will no longer ship about:home as the homepage. I don't
> > > > know if that's still planned for 57, but it hasn't happened yet.
> > > > 
> > > Until the last time of checking with the AS team (bug 1381716 comment 2),
> > > about:home will be the AS page.
> > 
> > My point was that it's not certain if we'll do this for 57. The comment you
> > link to was made a month ago, and it does not say that the transition of
> > about:home to AS is making 57, just that it will happen eventually. So the
> > comment doesn't address my point.
> Right, that should be a concern. Will check out the status with the AS team
> again.
> 
> (In reply to :Gijs from comment #6)
> > (In reply to Fischer [:Fischer] from comment #4)
> > > (In reply to Clément Lefèvre from comment #2)
> > > > So, to answer your questions:
> > > > 
> > > > 1/ Yes I'm seeing it every time, on my usual profile, on at least two
> > > > computers, I can try a third this evening.
> > > > 
> > > Hi Clément,
> > > Is you FF the FF57 nightly?
> > > If yes, this is expected because we added the tours for users updating to
> > > FF57 from the old FF.
> > 
> > That show up every startup and never go away, per comment #0? That doesn't seem right...
> All right, then this probably should let verdi comment here.
> For each tour, it got at most 16 times of being prompted with notificatoin
> if user didn't interact with it. Once user interacts (click the close/action
> button) with it, that tour wouldn't be prompted any more. Just that there
> are 6 tours so at minimum there would be 6 times of seeing tour
> notifications.

You mean, the fact I was not seeing it anymore after earlier upgrade may just be a result of having seen it many times each?

Comment 12

[Fischer [:Fischer]]

(In reply to :Gijs from comment #10)
> (In reply to Fischer [:Fischer] from comment #8)
> > For each tour, it got at most 16 times of being prompted with notificatoin
> > if user didn't interact with it. Once user interacts (click the close/action
> > button) with it, that tour wouldn't be prompted any more. Just that there
> > are 6 tours so at minimum there would be 6 times of seeing tour
> > notifications.
> 
> Sorry, so the user has to click the [x] 6 * 16 = 96 times?
No, only 6 times of [x]

Comment 13

[Fischer [:Fischer]]

(In reply to Fischer [:Fischer] from comment #12)
> (In reply to :Gijs from comment #10)
> > (In reply to Fischer [:Fischer] from comment #8)
> > > For each tour, it got at most 16 times of being prompted with notificatoin
> > > if user didn't interact with it. Once user interacts (click the close/action
> > > button) with it, that tour wouldn't be prompted any more. Just that there
> > > are 6 tours so at minimum there would be 6 times of seeing tour
> > > notifications.
> > 
> > Sorry, so the user has to click the [x] 6 * 16 = 96 times?
> No, only 6 times of [x]
Make it clear. There are 6 update user tours: performance,library,screenshots,singlesearch,customize,sync.
Assume a user clicks [x] upon seeing a notification right away so
1. The performance tour notification shows and user clicks to dismiss it, then performance tour notification never show again.
2. Next the library tour notification shows. User clicks to dismiss it, then library tour notification never show again.
3...6
After 6 clicks of [x], then no more tour notifications.

Comment 14

[Fischer [:Fischer]]

(In reply to Clément Lefèvre from comment #11)
> > All right, then this probably should let verdi comment here.
> > For each tour, it got at most 16 times of being prompted with notificatoin
> > if user didn't interact with it. Once user interacts (click the close/action
> > button) with it, that tour wouldn't be prompted any more. Just that there
> > are 6 tours so at minimum there would be 6 times of seeing tour
> > notifications.
> 
> You mean, the fact I was not seeing it anymore after earlier upgrade may just be a result of having seen it many times each?
Yes, that could be the case.
But would you talk more about what is "earlier upgrade"? I would like to make sure we are seeing the expected behaviors.
For my understanding, you are a regular FF nightly user. You didn't see the onboarding tours in FF56 nightly. Then started seeing tours after updating to the recent FF57 nightly. You saw tour notifications many times but no more of them after seeing so many times. Is my understanding correct? Thank you.

Comment 15

[Clément Lefèvre]

(In reply to Fischer [:Fischer] from comment #14)
> (In reply to Clément Lefèvre from comment #11)
> > > All right, then this probably should let verdi comment here.
> > > For each tour, it got at most 16 times of being prompted with notificatoin
> > > if user didn't interact with it. Once user interacts (click the close/action
> > > button) with it, that tour wouldn't be prompted any more. Just that there
> > > are 6 tours so at minimum there would be 6 times of seeing tour
> > > notifications.
> > 
> > You mean, the fact I was not seeing it anymore after earlier upgrade may just be a result of having seen it many times each?
> Yes, that could be the case.
> But would you talk more about what is "earlier upgrade"? I would like to
> make sure we are seeing the expected behaviors.
> For my understanding, you are a regular FF nightly user. You didn't see the
> onboarding tours in FF56 nightly. Then started seeing tours after updating
> to the recent FF57 nightly. You saw tour notifications many times but no
> more of them after seeing so many times. Is my understanding correct? Thank
> you.

To make it more clear:
Nightly is the version I always run on. Stable in only here to let me check regression cases, or other things like that.

I don't remember exactly when did I started to see this banner. However, once I started to see it I was seeing it every time I opened one of those tabs on at least two computers, and might check a third one.

Earlier upgrade referred to the one a couple of hours ago. Today's nightly rolled out maybe like 4H ago and after restarting with it I'm not seeing it anymore on my work computer.

This might be due to my numerous refreshes before the upgrade to test that bug and get back the banner with the scrolling issue though.

Comment 16

[Clément Lefèvre]

So, I cant't see this banner anymore with latest Nightly on all of my three installations, on the three OS.

But looking at above comments, it looks like this should come back at some points? So I guess there is still the fact it hides buttons to take care about.

Comment 17

[Fischer [:Fischer]]

(In reply to Clément Lefèvre from comment #16)
> So, I cant't see this banner anymore with latest Nightly on all of my three
> installations, on the three OS.
> 
> But looking at above comments, it looks like this should come back at some
> points? So I guess there is still the fact it hides buttons to take care
> about.
Per the bug 1381716 comment 5, the Activity-Stream page is going to replace the old about:home page so this case of covering the bottom buttons will be gone.

Comment 18

[Verdi [:verdi] Best to slack me]

The logic on the notifications right now is: 
* They start on the first new tab that is opened at least 5 min after installation
* We only show them for the parts of the tour that are not complete
* Each one (there are 6) gets 8 impressions before going away if the user doesn't interact with it. 
* Notifications that are not interacted with are put into a queue and each gets 8 more impressions (assuming the user doesn't interact with or dismiss them). 
After that, snippets will begin to be displayed in their place.