Closed
Bug 1392286
Opened 8 years ago
Closed 8 years ago
App to display generated sources code in S3 by URL (maybe)
Categories
(Socorro :: Webapp, task)
Socorro
Webapp
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: peterbe, Unassigned)
References
Details
In https://bugzilla.mozilla.org/show_bug.cgi?id=1389217 Ted added a new thing so that crashing frames contain frame references to source code that is uploaded and available in a S3 bucket.
To view these source you can download the files (e.g. `curl --compressed https://gecko-generated-sources.s3.amazonaws.com/36d62ce2ec2925f4a13e44fe534b246c23b4b3d5407884d3bbfc9b0d9aebe4929985935ae582704c06e994ece0d1e76528ff1edf4543e400d0aaa8f7251b15ca/ipc/ipdl/PCompositorBridgeChild.cpp > PCompositorBridgeChild.cpp`)
And the line to look for is inside the frame itself.
However, having to download them is tedious so Ted made a little Heroku app that does the S3 download, converts the source code to highlit HTML and displays with with a nice anchor link to the relevant line.
The "problem" with this is...
* Socorro now has a hardcoded (in webapp-django/crashstats/settings/base.py) dependency on an external service which we can't "vouch" for other than let's hope it's up.
* The Heroku app is owned and run by Ted. Although we can move it to the Mozilla corp account on Heroku.
* More "scattered" services that might add more confusion for the teams involved.
* Opening URLs on this is currently hecka' slow. Perhaps because it's a free tier app and the dynos are sleeping a lot.
Our options are...
1. Just leave it as it is. And "do nothing".
2. Option 1 but that we move the Flask app to the "mozilla" org and move the Heroku app instance to the Mozilla corp account. (Good bus-factor practice)
3. Build a Django view that does the same. A requests.get() plus some pygments code to produce the HTML.
4. Find another general service (think SaaS) that highlights source code by URL.
Comment 1•8 years ago
|
||
The code for Ted's app is here:
https://github.com/luser/source-highlight/blob/master/app.py
That's pretty trivial. Seems like the best option here is to roll that into a view in the webapp.
| Reporter | ||
Comment 2•8 years ago
|
||
For the record; the app is https://dashboard.heroku.com/apps/source-highlight
And it's been moved the Mozilla corp account.
| Reporter | ||
Comment 3•8 years ago
|
||
We just put it into the Django webapp.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1392236#c5
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•