Closed
Bug 1392318
Opened 7 years ago
Closed 7 years ago
Use fromJSON convention in action module
Categories
(Remote Protocol :: Marionette, enhancement)
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
References
Details
Attachments
(1 file)
The convention is to name an object’s JSON marshaling method "toJSON" so that it is implicitly picked up by JSON.stringify({toJSON: () => "…"}).
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Assignee | ||
Updated•7 years ago
|
Summary: Use toJSON convention in action module → Use fromJSON convention in action module
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
This doesn’t really block marionette-window-tracking, but I’m trying to split that WIP patch up in landable chunks.
Blocks: marionette-window-tracking
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8899535 [details] Bug 1392318 - Use fromJSON convention in action module. https://reviewboard.mozilla.org/r/170820/#review176338
Attachment #8899535 -
Flags: review?(dburns) → review+
Comment 5•7 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 504672c4fdfd -d 5b82c36142fb: rebasing 415095:504672c4fdfd "Bug 1392318 - Use fromJSON convention in action module. r=automatedtester" (tip) merging testing/marionette/action.js merging testing/marionette/listener.js warning: conflicts while merging testing/marionette/listener.js! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request) |
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f70b43ea56cc Use fromJSON convention in action module. r=automatedtester
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f70b43ea56cc
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•