Closed Bug 1392323 Opened 4 years ago Closed 4 years ago

Correct misuse of pprint in action module

Categories

(Testing :: Marionette, defect)

Product:
Testing
Component:
Marionette
Version:
Version 3
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox57 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: ato, Assigned: ato)

References

Details

Attachments

(1 file)

Bug 1392323 - Correct use of pprint in action module.
59 bytes, text/x-review-board-request
automatedtester
: review+
Details 
In certain places, the Marionette action module calls error.pprint
as if it is a function. pprint is a ES6 string template and should
be used like pprint`${replacement}`.
Assignee: nobody → ato
Status: NEW → ASSIGNED
This doesn’t block marionette-window-tracking so much, but I am
trying to split up that patch into landable chunks.
(In reply to Andreas Tolfsen ‹:ato› from comment #3)
> This doesn’t block marionette-window-tracking so much, but I am
> trying to split up that patch into landable chunks.

Now it does block it, so I’m slightly overloading the meaning of
a blocking bug to keep track of the individual chunks.
Blocks: marionette-window-tracking
Comment on attachment 8899540 [details]
Bug 1392323 - Correct use of pprint in action module.

https://reviewboard.mozilla.org/r/170828/#review176340
Attachment #8899540 - Flags: review?(dburns) → review+
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/85c71fd3d6aa
Correct use of pprint in action module. r=automatedtester
https://hg.mozilla.org/mozilla-central/rev/85c71fd3d6aa
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.