1392323 - Correct misuse of pprint in action module

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

In certain places, the Marionette action module calls error.pprint
as if it is a function. pprint is a ES6 string template and should
be used like pprint`${replacement}`.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1392323 - Correct use of pprint in action module.

In certain places, the Marionette action module calls error.pprint as
if it is a function.  pprint is a ES6 string template and should be used
like pprint`${replacement}`.

Review commit: https://reviewboard.mozilla.org/r/170828/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/170828/

Comment 2

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8899540 [details]
Bug 1392323 - Correct use of pprint in action module.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/170828/diff/1-2/

Comment 3

[Andreas Tolfsen ❲:ato❳]

This doesn’t block marionette-window-tracking so much, but I am
trying to split up that patch into landable chunks.

Comment 4

[Andreas Tolfsen ❲:ato❳]

(In reply to Andreas Tolfsen ‹:ato› from comment #3)
> This doesn’t block marionette-window-tracking so much, but I am
> trying to split up that patch into landable chunks.

Now it does block it, so I’m slightly overloading the meaning of
a blocking bug to keep track of the individual chunks.

Comment 5

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8899540 [details]
Bug 1392323 - Correct use of pprint in action module.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/170828/diff/2-3/

Comment 6

[David Burns :automatedtester]

Comment on attachment 8899540 [details]
Bug 1392323 - Correct use of pprint in action module.

https://reviewboard.mozilla.org/r/170828/#review176340

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85c71fd3d6aa
Correct use of pprint in action module. r=automatedtester

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/85c71fd3d6aa