Closed
Bug 1392323
Opened 8 years ago
Closed 8 years ago
Correct misuse of pprint in action module
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
References
Details
Attachments
(1 file)
In certain places, the Marionette action module calls error.pprint
as if it is a function. pprint is a ES6 string template and should
be used like pprint`${replacement}`.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•8 years ago
|
||
This doesn’t block marionette-window-tracking so much, but I am
trying to split up that patch into landable chunks.
Assignee | ||
Comment 4•8 years ago
|
||
(In reply to Andreas Tolfsen ‹:ato› from comment #3)
> This doesn’t block marionette-window-tracking so much, but I am
> trying to split up that patch into landable chunks.
Now it does block it, so I’m slightly overloading the meaning of
a blocking bug to keep track of the individual chunks.
Blocks: marionette-window-tracking
Comment hidden (mozreview-request) |
Comment 6•8 years ago
|
||
mozreview-review |
Comment on attachment 8899540 [details]
Bug 1392323 - Correct use of pprint in action module.
https://reviewboard.mozilla.org/r/170828/#review176340
Attachment #8899540 -
Flags: review?(dburns) → review+
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/85c71fd3d6aa
Correct use of pprint in action module. r=automatedtester
Comment 8•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•