Closed
Bug 1392382
Opened 7 years ago
Closed 6 years ago
Intermittent dom/tests/mochitest/script/test_bug1053321.html | Test timed out | Deferred script executed before DOMContentLoaded
Categories
(Core :: DOM: Core & HTML, defect, P5)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla59
People
(Reporter: intermittent-bug-filer, Assigned: mayhemer)
References
Details
(Keywords: intermittent-failure)
Attachments
(2 files)
2.74 KB,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
1.29 KB,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
Filed by: rvandermeulen [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=124629539&repo=mozilla-beta https://queue.taskcluster.net/v1/task/dUbMY-sdQk-2Xf0d-xz2iQ/runs/0/artifacts/public/logs/live_backing.log
Assignee | ||
Comment 2•7 years ago
|
||
defer scripts MUST execute before DOMContentLoaded, so the problem is apparently somewhere else. The script didn't load, what is supported by: *** error running SJS at /home/worker/workspace/build/tests/mochitest/tests/dom/tests/mochitest/script/file_blocked_script.sjs: TypeError: x is null on line 18 So, it looks like the requests ended up on the server in an opposite order. This could happen on some rare occasions and it might be caused bug 1392264. However, that bug doesn't ensure the order of delivery of requests on the server. The test needs a fix, it's simple.
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Flags: needinfo?(honzab.moz)
Assignee | ||
Comment 3•7 years ago
|
||
Simply count with a possibility of the requests coming in the opposite order.
Attachment #8900748 -
Flags: review?(bkelly)
Updated•7 years ago
|
Attachment #8900748 -
Flags: review?(bkelly) → review+
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/76c3595b3d37 Don't assume request order in test_bug1053321.html. r=bkelly
Keywords: checkin-needed
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/76c3595b3d37
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•7 years ago
|
status-firefox56:
--- → affected
Assignee | ||
Comment 7•7 years ago
|
||
Comment on attachment 8900748 [details] [diff] [review] v1 Approval Request Comment: the same test suffering likely the same issue is already on beta.
Attachment #8900748 -
Flags: approval-mozilla-beta?
Comment 8•7 years ago
|
||
Comment on attachment 8900748 [details] [diff] [review] v1 This can land a=test-only. I'll get it as a ride-along next time I'm pushing uplifts.
Attachment #8900748 -
Flags: approval-mozilla-beta?
Assignee | ||
Comment 9•7 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #8) > Comment on attachment 8900748 [details] [diff] [review] > v1 > > This can land a=test-only. I'll get it as a ride-along next time I'm pushing > uplifts. Thanks, Ryan.
Comment 10•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/f1c9e3110921
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 19•7 years ago
|
||
Fail still reproduces on Linux x64 Stylo Disabled debug. Treeherder: https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&selectedJob=142319068 Log: INFO - SimpleTest START INFO - TEST-START | dom/tests/mochitest/script/test_bug1053321.html INFO - GECKO(1805) | ++DOMWINDOW == 7 (0x7fab01b21000) [pid = 1860] [serial = 7] [outer = 0x7fab01b10800] INFO - GECKO(1805) | ++DOMWINDOW == 8 (0x7fab019a5800) [pid = 1860] [serial = 8] [outer = 0x7fab01b10800] INFO - *** error running SJS at /builds/worker/workspace/build/tests/mochitest/tests/dom/tests/mochitest/script/file_blocked_script.sjs: 2147549183 on line NaN INFO - TEST-INFO | started process screentopng INFO - TEST-INFO | screentopng: exit 0 INFO - TEST-UNEXPECTED-FAIL | dom/tests/mochitest/script/test_bug1053321.html | Deferred script executed before DOMContentLoaded INFO - @dom/tests/mochitest/script/test_bug1053321.html:32:7 INFO - EventListener.handleEvent*@dom/tests/mochitest/script/test_bug1053321.html:31:5 INFO - TEST-PASS | dom/tests/mochitest/script/test_bug1053321.html | Script async executed INFO - GECKO(1805) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration. INFO - GECKO(1805) | MEMORY STAT | vsize 1615MB | residentFast 103MB | heapAllocated 22MB INFO - TEST-PASS | dom/tests/mochitest/script/test_bug1053321.html | Async script executed before onload INFO - GECKO(1805) | --DOCSHELL 0x7fa149524000 == 3 [pid = 1805] [id = {84a17b74-9931-4524-8b2f-5e2e2d7113f6}] INFO - TEST-OK | dom/tests/mochitest/script/test_bug1053321.html | took 1926ms
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 24•6 years ago
|
||
*** error running SJS at /builds/worker/workspace/build/tests/mochitest/tests/dom/tests/mochitest/script/file_blocked_script.sjs: 2147549183 on line NaN Not very helpful. Let's add try-catch stmts around likely affected places.
Assignee | ||
Comment 25•6 years ago
|
||
So, I was calling response.finish() on a response that has not been processAsync()'ed. This patch fixes that.
Attachment #8933332 -
Flags: review?(bkelly)
Updated•6 years ago
|
Attachment #8933332 -
Flags: review?(bkelly) → review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Updated•6 years ago
|
Comment 26•6 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/65fdb046a529 Fix test_bug1053321.html from intermittent failures. r=bkelly
Keywords: checkin-needed
Comment 27•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/65fdb046a529
Status: NEW → RESOLVED
Closed: 7 years ago → 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Comment 28•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/f75ad2573f47
Comment hidden (Intermittent Failures Robot) |
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•