Closed Bug 1392382 Opened 7 years ago Closed 6 years ago

Intermittent dom/tests/mochitest/script/test_bug1053321.html | Test timed out | Deferred script executed before DOMContentLoaded

Categories

(Core :: DOM: Core & HTML, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox56 --- fixed
firefox57 --- fixed
firefox58 --- fixed
firefox59 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: mayhemer)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

Any ideas what could be happening here, Honza?
Flags: needinfo?(honzab.moz)
defer scripts MUST execute before DOMContentLoaded, so the problem is apparently somewhere else.  The script didn't load, what is supported by:

*** error running SJS at /home/worker/workspace/build/tests/mochitest/tests/dom/tests/mochitest/script/file_blocked_script.sjs: TypeError: x is null on line 18

So, it looks like the requests ended up on the server in an opposite order.  This could happen on some rare occasions and it might be caused bug 1392264.  However, that bug doesn't ensure the order of delivery of requests on the server. 

The test needs a fix, it's simple.
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Flags: needinfo?(honzab.moz)
Attached patch v1Splinter Review
Simply count with a possibility of the requests coming in the opposite order.
Attachment #8900748 - Flags: review?(bkelly)
Attachment #8900748 - Flags: review?(bkelly) → review+
Thanks!
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/76c3595b3d37
Don't assume request order in test_bug1053321.html. r=bkelly
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/76c3595b3d37
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment on attachment 8900748 [details] [diff] [review]
v1

Approval Request Comment: the same test suffering likely the same issue is already on beta.
Attachment #8900748 - Flags: approval-mozilla-beta?
Comment on attachment 8900748 [details] [diff] [review]
v1

This can land a=test-only. I'll get it as a ride-along next time I'm pushing uplifts.
Attachment #8900748 - Flags: approval-mozilla-beta?
(In reply to Ryan VanderMeulen [:RyanVM] from comment #8)
> Comment on attachment 8900748 [details] [diff] [review]
> v1
> 
> This can land a=test-only. I'll get it as a ride-along next time I'm pushing
> uplifts.

Thanks, Ryan.
Fail still reproduces on Linux x64 Stylo Disabled debug.
Treeherder: https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&selectedJob=142319068

Log:
INFO - SimpleTest START
INFO - TEST-START | dom/tests/mochitest/script/test_bug1053321.html
INFO - GECKO(1805) | ++DOMWINDOW == 7 (0x7fab01b21000) [pid = 1860] [serial = 7] [outer = 0x7fab01b10800]
INFO - GECKO(1805) | ++DOMWINDOW == 8 (0x7fab019a5800) [pid = 1860] [serial = 8] [outer = 0x7fab01b10800]
INFO -  *** error running SJS at /builds/worker/workspace/build/tests/mochitest/tests/dom/tests/mochitest/script/file_blocked_script.sjs: 2147549183 on line NaN
INFO - TEST-INFO | started process screentopng
INFO - TEST-INFO | screentopng: exit 0
INFO - TEST-UNEXPECTED-FAIL | dom/tests/mochitest/script/test_bug1053321.html | Deferred script executed before  DOMContentLoaded 
INFO -     @dom/tests/mochitest/script/test_bug1053321.html:32:7
INFO -     EventListener.handleEvent*@dom/tests/mochitest/script/test_bug1053321.html:31:5
INFO - TEST-PASS | dom/tests/mochitest/script/test_bug1053321.html | Script async executed 
INFO - GECKO(1805) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
INFO - GECKO(1805) | MEMORY STAT | vsize 1615MB | residentFast 103MB | heapAllocated 22MB
INFO - TEST-PASS | dom/tests/mochitest/script/test_bug1053321.html | Async script executed before onload 
INFO - GECKO(1805) | --DOCSHELL 0x7fa149524000 == 3 [pid = 1805] [id = {84a17b74-9931-4524-8b2f-5e2e2d7113f6}]
INFO - TEST-OK | dom/tests/mochitest/script/test_bug1053321.html | took 1926ms
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Will look.
Status: REOPENED → NEW
*** error running SJS at /builds/worker/workspace/build/tests/mochitest/tests/dom/tests/mochitest/script/file_blocked_script.sjs: 2147549183 on line NaN

Not very helpful.  Let's add try-catch stmts around likely affected places.
So, I was calling response.finish() on a response that has not been processAsync()'ed.  This patch fixes that.
Attachment #8933332 - Flags: review?(bkelly)
Attachment #8933332 - Flags: review?(bkelly) → review+
Keywords: checkin-needed
Target Milestone: mozilla57 → ---
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/65fdb046a529
Fix test_bug1053321.html from intermittent failures. r=bkelly
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/65fdb046a529
Status: NEW → RESOLVED
Closed: 7 years ago6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.