1392403 - about:telemetry - ping selector popup is sometimes hard to dismiss

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Chris H-C :chutten]

From the etherpad[1]:

    Sometimes is impossible to close the current ping/archive floating panel. STR:

    Go to about:telemetry

    Click on "current ping"

    Click on "Histograms"

    The floating panel doesn't get closed

[1]: https://public.etherpad-mozilla.org/p/about_telemetry_feedback

Comment 1

[flyingrub]

Attachment: Bug 1392403 - Ease the dismiss of the popup in about:telemetry

Fix ping selector popup is sometimes hard to dismiss.

Review commit: https://reviewboard.mozilla.org/r/171116/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171116/

Comment 2

[Chris H-C :chutten]

Comment on attachment 8899778 [details]
Bug 1392403 - Ease the dismiss of the popup in about:telemetry

https://reviewboard.mozilla.org/r/171116/#review176256

Not a fan of mouseleave in this case. And what happens for people using touch to interact with the page? (silly fools :D )

How about a "X" at the top-right? It's an old design, but it checks out.

Comment 3

[Chris H-C :chutten]

Or, now that we have the down-arrow, maybe turn it into an up arrow when the popup is open and have clicking that dismiss the popup?

Comment 4

[flyingrub]

Comment on attachment 8899778 [details]
Bug 1392403 - Ease the dismiss of the popup in about:telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/171116/diff/1-2/

Comment 5

[Chris H-C :chutten]

Comment on attachment 8899778 [details]
Bug 1392403 - Ease the dismiss of the popup in about:telemetry

https://reviewboard.mozilla.org/r/171116/#review176826

It looks as though this might end up being fragile, but we can give it a try.

Comment 6

[flyingrub]

I also tried to add a scaleY(-1) to rotate the icon but it rotate also the text. Perhaps we can open another bug for it ?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16b6c9d86e7f
Ease the dismiss of the popup in about:telemetry r=chutten

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/16b6c9d86e7f