Closed Bug 1392407 Opened 4 years ago Closed 4 years ago

about:telemetry Sometimes "Raw JSON" errors out

Categories

(Toolkit :: Telemetry, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: chutten, Assigned: flyingrub)

References

Details

Attachments

(1 file)

* If the Raw JSON contains an "interesting" character, it can cause a InvalidCharacterError when using btoa to format the data uri 

I'm not sure what bwinton had in his payload that failed btoa, but it's possible. In that case it would be acceptable to catch the exception and display the raw json inline instead of popping a new window to use the JSON viewer.
Comment on attachment 8900674 [details]
Bug 1392407 - Fix about:telemetry issue with btoa

https://reviewboard.mozilla.org/r/172104/#review177472

Can we wrap this in a try { } catch () { show-the-raw-json-like-if-theres-a-render-error(); } ?
Attachment #8900674 - Flags: review?(chutten) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/cadbabe9cb86
Fix about:telemetry issue with btoa r=chutten
Keywords: checkin-needed
Flags: needinfo?(flyinggrub)
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a4ff4582ad4d
Fix about:telemetry issue with btoa r=chutten
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a4ff4582ad4d
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.