about:telemetry Sometimes "Raw JSON" errors out

RESOLVED FIXED in Firefox 57

Status

()

enhancement
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: chutten, Assigned: flyingrub)

Tracking

(Blocks 1 bug)

unspecified
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

2 years ago
* If the Raw JSON contains an "interesting" character, it can cause a InvalidCharacterError when using btoa to format the data uri 

I'm not sure what bwinton had in his payload that failed btoa, but it's possible. In that case it would be acceptable to catch the exception and display the raw json inline instead of popping a new window to use the JSON viewer.
Comment hidden (mozreview-request)
Reporter

Comment 3

2 years ago
mozreview-review
Comment on attachment 8900674 [details]
Bug 1392407 - Fix about:telemetry issue with btoa

https://reviewboard.mozilla.org/r/172104/#review177472

Can we wrap this in a try { } catch () { show-the-raw-json-like-if-theres-a-render-error(); } ?
Attachment #8900674 - Flags: review?(chutten) → review+
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Keywords: checkin-needed

Comment 5

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/cadbabe9cb86
Fix about:telemetry issue with btoa r=chutten
Keywords: checkin-needed
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Flags: needinfo?(flyinggrub)
Keywords: checkin-needed

Comment 8

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a4ff4582ad4d
Fix about:telemetry issue with btoa r=chutten
Keywords: checkin-needed

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a4ff4582ad4d
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.