1392407 - about:telemetry Sometimes "Raw JSON" errors out

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P1)

Description

[Chris H-C :chutten]

* If the Raw JSON contains an "interesting" character, it can cause a InvalidCharacterError when using btoa to format the data uri 

I'm not sure what bwinton had in his payload that failed btoa, but it's possible. In that case it would be acceptable to catch the exception and display the raw json inline instead of popping a new window to use the JSON viewer.

Comment 1

[flyingrub]

Attachment: Bug 1392407 - Fix about:telemetry issue with btoa

Review commit: https://reviewboard.mozilla.org/r/172104/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172104/

Comment 2

[flyingrub]

Use a solution from MDN : https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope/btoa#Unicode_strings

Comment 3

[Chris H-C :chutten]

Comment on attachment 8900674 [details]
Bug 1392407 - Fix about:telemetry issue with btoa

https://reviewboard.mozilla.org/r/172104/#review177472

Can we wrap this in a try { } catch () { show-the-raw-json-like-if-theres-a-render-error(); } ?

Comment 4

[flyingrub]

Comment on attachment 8900674 [details]
Bug 1392407 - Fix about:telemetry issue with btoa

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172104/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cadbabe9cb86
Fix about:telemetry issue with btoa r=chutten

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for eslint failure at toolkit/content/aboutTelemetry.js:2065: Multiple spaces found before '{':

https://hg.mozilla.org/integration/autoland/rev/68109e7e1c93cb4ee792dd5666706789386d4fec

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=cadbabe9cb8654db30d0b524b7fed9d5d22ef9b6&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=125954910&repo=autoland
> TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/toolkit/content/aboutTelemetry.js:2065:16 | Multiple spaces found before '{'. (no-multi-spaces)

Comment 7

[flyingrub]

Comment on attachment 8900674 [details]
Bug 1392407 - Fix about:telemetry issue with btoa

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172104/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4ff4582ad4d
Fix about:telemetry issue with btoa r=chutten

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a4ff4582ad4d