Stack trace doesn't exist in 'cause' for WebSocket connections

RESOLVED FIXED in Firefox 68

Status

enhancement
P3
normal
RESOLVED FIXED
2 years ago
2 months ago

People

(Reporter: bgrins, Assigned: bhackett)

Tracking

(Blocks 1 bug, Regressed 1 bug)

unspecified
Firefox 68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 wontfix, firefox68 fixed)

Details

(Whiteboard: [debugger-mvp])

Attachments

(3 attachments)

We don't get a stack trace pointing back to the call that opens a WebSocket connection. For instance, on https://html5demos.com/web-socket/ it should point back to the line that does `new WebSocket(...)`.
Product: Firefox → DevTools
Blocks: dbg-stacks
Assignee: nobody → bhackett1024
Blocks: 1546736
Status: NEW → ASSIGNED
Whiteboard: [debugger-mvp]
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e2f3fc37e2e
Part 1 - Report stacks to net monitor when creating web sockets, r=bzbarsky.
https://hg.mozilla.org/integration/mozilla-inbound/rev/fce11a50c058
Part 2 - Report stacks for websocket construction in net monitor, r=ochameau.
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c23ba0f835f
Part 3 - Add test for capturing websocket stacks in net monitor, r=ochameau.

Backed out for failures on /browser_net_websocket_stacks.js

backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/a67530e635b1a1b676a101150ac4c0e4cb73801b

push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=c37ca68a24e5a38192a1ef8ccf01c406ccc511ce&group_state=expanded

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=246950900&repo=mozilla-inbound&lineNumber=3902

01:15:03 INFO - > Network event progress: NetworkEvent: 1/4, PayloadReady: 1/4, got NetMonitor:NetworkEvent for server1.conn134.netEvent23
01:15:03 INFO - Console message: [JavaScript Error: "TypeError: this is undefined" {file: "http://example.com/browser/devtools/client/netmonitor/test/html_websocket-test-page.html" line: 6}]
01:15:03 INFO - openSocket@http://example.com/browser/devtools/client/netmonitor/test/html_websocket-test-page.html:6:13
01:15:03 INFO - @http://example.com/browser/devtools/client/netmonitor/test/html_websocket-test-page.html:3:1
01:15:03 INFO -
01:15:03 INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.com/browser/devtools/client/netmonitor/test/html_websocket-test-page.html" line: 0}]
01:15:03 INFO - > Network event progress: NetworkEvent: 2/4, PayloadReady: 1/4, got NetMonitor:NetworkEvent for server1.conn134.netEvent42
01:15:03 INFO - Buffered messages logged at 01:13:35
01:15:03 INFO - Console message: [JavaScript Error: "Firefox can’t establish a connection to the server at ws://localhost:8080/." {file: "http://example.com/browser/devtools/client/netmonitor/test/html_websocket-test-page.html" line: 6}]
01:15:03 INFO - > Network event progress: NetworkEvent: 2/4, PayloadReady: 2/4, got NetMonitor:PayloadReady for server1.conn134.netEvent42
01:15:03 INFO - Buffered messages finished
01:15:03 INFO - TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_websocket_stacks.js | Test timed out -
01:15:03 INFO - GECKO(5864) | console.warn: "Error while detaching the thread front: 'detach' request packet to 'server1.conn134.child1/context18' can't be sent as the connection is closed."
01:15:03 INFO - Removing tab.
01:15:03 INFO - Waiting for event: 'TabClose' on [object XULElement].
01:15:03 INFO - Got event: 'TabClose' on [object XULElement].
01:15:03 INFO - Tab removed and finished closing
01:15:03 INFO - finish() was called, cleaning up...
01:15:03 INFO - GECKO(5864) | MEMORY STAT | vsize 19406354MB | vsizeMaxContiguous 65796484MB | residentFast 2021MB
01:15:03 INFO - TEST-OK | devtools/client/netmonitor/test/browser_net_websocket_stacks.js | took 90746ms

Flags: needinfo?(bhackett1024)
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/541a6a19a385
Part 1 - Report stacks to net monitor when creating web sockets, r=bzbarsky.
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e0d5c61f31e
Part 2 - Report stacks for websocket construction in net monitor, r=ochameau.
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4af6879f495
Part 3 - Add test for capturing websocket stacks in net monitor, r=ochameau.
Regressions: 1552758
Regressions: 1552757
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Flags: needinfo?(bhackett1024)
You need to log in before you can comment on or make changes to this bug.