51 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
The systemtests are currently broken because they depended on certain symbols being uploaded. When we switched to the new S3 buckets and stopped having the old web-eng S3 URI as a fallback, things failed. Let's upload all the relevant and missing symbols into Dev, Stage and Prod. That'll unbreak the systemtests for Dev, Stage and Prod. The symbols to upload should be kept in the repo so it can be re-used for local docker dev when a developer starts from a clean slate (ie. an empty S3 mock server).
Created attachment 8899931 [details] [review] Link to GitHub pull-request: https://github.com/mozilla-services/tecken/pull/337
Commit pushed to master at https://github.com/mozilla-services/tecken https://github.com/mozilla-services/tecken/commit/0d4da2c15117094b4f8a1fd03c83756557b78966 fixes bug 1392424 - Unbreak systemtests with real symbol files (#337) * fixes bug 1392424 - Unbreak systemtests with real symbol files * update docs
Code kinda ready but right now a chicken and egg problem. I can't prime Dev and Stage (prod should be taken care of by the AWS S3 migration script process) because API tokens are disabled by default. Meaning, I can't do an upload to Dev and Stage using curl no matter how hard I try. And even though the default has been changed (in master) so that it's enabled by default . Let's close this once Dev and Stage has these symbols in it.  https://github.com/mozilla-services/tecken/commit/62ba02db88fec9fb941822534cd459568f44d8f8
Dev and stage's S3 buckets now have all the necessary symbols that the systemtests assume are there.