1392483 - All builds will be busted when Gecko 57 merges to Beta on 2017-09-20

Status: VERIFIED FIXED

(Core :: XPCOM, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Broken builds on the next merge day.

Please fix this ASAP since it blocks finding any other test bustage in the mean time.

https://treeherder.mozilla.org/logviewer.html#?job_id=124742138&repo=try

/home/worker/workspace/build/src/xpcom/threads/nsThread.h:108:54: error: 'mNextIdleDeadline' was not declared in this scope
/home/worker/workspace/build/src/xpcom/threads/nsThread.h:108:73: error: control reaches end of non-void function [-Werror=return-type

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Sorry, I should have noted that the patch below is all that's needed to reproduce:
https://hg.mozilla.org/try/rev/29b9b0554ddf5031f0300418676dc01624c41a6f

Comment 2

[Andrew McCreight [:mccr8]]

I'm taking a look at this. Hopefully it won't be too hard to fix.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1392483 - ifdef out mNextIdleDeadline in a few more places.

Review commit: https://reviewboard.mozilla.org/r/171332/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171332/

Comment 4

[Andrew McCreight [:mccr8]]

This is pretty ugly but it works. Maybe in the long run there should be a nicer way to deal with these fields not always being around (like a setter that just does nothing outside of Nightly).

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 8900009 [details]
Bug 1392483 - ifdef out mNextIdleDeadline in a few more places.

https://reviewboard.mozilla.org/r/171332/#review176554

We don't have a good solution for this sort of thing, and having a `NightlyOrBeta<T>` type or something like that would consume space in release builds.  You could stuff it in an inherited-from class, which wouldn't consume space, but that's a little awkward...maybe that would help people more tightly compartimentalize functionality?

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8900009 [details]
Bug 1392483 - ifdef out mNextIdleDeadline in a few more places.

This doesn't appear to work, unfortunately. Just moves the bustage to SchedulerGroup.cpp.
https://treeherder.mozilla.org/logviewer.html#?job_id=125036424&repo=try

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8900009 [details]
Bug 1392483 - ifdef out mNextIdleDeadline in a few more places.

Nevermind, those failures are there even when I use the cobbled-together backout patch I used last night.

Interestingly, those failures only happen on Linux builds and only when the EARLY_BETA_OR_EARLIER flag is reset - i.e. https://hg.mozilla.org/try/rev/e99b9c1810d9624b644ad1d67439f7eae985f667 (which normally happens around the halfway point of the cycle). Anyway, I'll file the bug and follow-up there.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbabaeec0fbc
ifdef out mNextIdleDeadline in a few more places. r=froydnj

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/dbabaeec0fbc

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

This is fixed, no need to track it.