Closed Bug 1392502 Opened 4 years ago Closed 4 years ago

Fix 2d/3d transform check in StackingContextHelper

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: ethlin, Assigned: ethlin)

References

Details

Attachments

(1 file)

I think the check at [1] is wrong. The nullptr aTransformPtr doesn't mean it's a 2d transform. This causes some try failures. I'll fix it.

[1] https://dxr.mozilla.org/mozilla-central/rev/a9d372645a32b8d23d44244f351639af9d73b96a/gfx/layers/wr/StackingContextHelper.cpp#82
We should take null transform as a 2D transform (identity transform).
We can use "layout/reftests/bugs/635302-1.html" to test.
Comment on attachment 8899702 [details]
Bug 1392502 - Fix 2d/3d transform check in StackingContextHelper.

https://reviewboard.mozilla.org/r/171016/#review176190
Attachment #8899702 - Flags: review?(mtseng) → review+
Pushed by ethlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/224998af578c
Fix 2d/3d transform check in StackingContextHelper. r=mtseng
https://hg.mozilla.org/mozilla-central/rev/224998af578c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.