Closed Bug 1392517 Opened 2 years ago Closed 2 years ago

Add 2nd header to about:preferences#sync and update button string

Categories

(Firefox :: Preferences, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 57
Tracking Status
firefox57 --- verified

People

(Reporter: rickychien, Assigned: rickychien)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [photon-preference])

Attachments

(1 file)

Bug 1390499 follow to add second level header for "Firefox Account" page. Bug 1390499 was missing the support of 2nd level header. We should add it as well.
Summary: Add second level header to Firefox Account page → Add 2nd header to about:preferences#sync and update button string
Blocks: 1357306
No longer blocks: photon-preference
This bug will update two button strings to match the Photon copy rule https://bwinton.github.io/photon/copy/word-list.html#e
Whiteboard: [photon-preference][triage] → [photon-preference]
Comment on attachment 8899710 [details]
Bug 1392517 - Add 2nd header to about:preferences#sync and update button string

https://reviewboard.mozilla.org/r/171034/#review177050

Thanks!

::: browser/locales/en-US/chrome/browser/preferences/sync.dtd:61
(Diff revision 4)
> -<!ENTITY verify.label                "Verify Email">
> -<!ENTITY verify.accesskey            "V">
> -<!ENTITY forget.label                "Forget this Email">
> -<!ENTITY forget.accesskey            "F">
> +<!ENTITY verify2.label               "Verify email">
> +<!ENTITY verify2.accesskey           "V">
> +<!ENTITY forget2.label               "Forget this email">
> +<!ENTITY forget2.accesskey           "F">

Updating casing doesn't require a key bump, so we can keep the keys the same.
Attachment #8899710 - Flags: review?(mconley) → review+
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e4d8b460607f
Add 2nd header to about:preferences#sync and update button string r=mconley
https://hg.mozilla.org/mozilla-central/rev/e4d8b460607f
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Build ID: 20170828100127
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Depends on: 1467173
Depends on: 1467173
You need to log in before you can comment on or make changes to this bug.