Closed Bug 1392591 Opened 4 years ago Closed 2 years ago
.notifications .on Clicked callback get erroneous second parameter
47 bytes, text/x-phabricator-request
|Details | Review|
A browser.notifications.onClicked callback is supposed to get called with a single parameter, (notificationId) while in fact it gets called with two parameters (notificationId, true). This seems to be a copypaste mistake (copying onClosed). I ran into this when registering onClicked/onButtonClicked to the same listener function, expecting the second parameter to be either a button index (well, not in Firefox, no buttons yet) or undefined .  https://hg.mozilla.org/mozilla-central/annotate/f91054a848d6/toolkit/components/extensions/ext-notifications.js#l135
Yes, this looks like a bug and a simple one to fix. I'll take it.
Assignee: nobody → bob.silverberg
Assignee: mstriemer → nobody
You need to log in before you can comment on or make changes to this bug.