Remove toolkit/crashreporter/tools/win32

RESOLVED FIXED in Firefox 66

Status

()

enhancement
RESOLVED FIXED
2 years ago
3 months ago

People

(Reporter: ted, Assigned: ted)

Tracking

unspecified
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

We have prebuilt dump_syms binaries in toolkit/crashreporter/tools/win32 from the days when we didn't build it as part of the build. There's one per MSVC version, since the APIs it uses are version-specific, but we don't actually support building with the MSVC versions corresponding to the binaries in that directory anymore, so we should just remove them.
The only place that even references this now is unit-symbolstore.py:
https://dxr.mozilla.org/mozilla-central/rev/f0abd25e1f4acced652d180c34b7c9eda638deb1/toolkit/crashreporter/tools/unit-symbolstore.py#463

...but that test is already broken because we don't have a prebuilt binary for MSVC 2015 or 2017.
We have prebuilt dump_syms binaries in toolkit/crashreporter/tools/win32 from
the days when we didn't build it as part of the build. There's one per MSVC
version, since the APIs it uses are version-specific, but we don't actually
support building with the MSVC versions corresponding to the binaries in that
directory anymore, so we should just remove them.

The only code change necessary here is changing the functional test to skip
running the test if a dump_syms binary isn't available.

MozReview-Commit-ID: IBuJZMVfv7C
Apparently I have had this patch sitting in my local repo for a while.
Assignee: nobody → ted

Comment 4

3 months ago
Pushed by tmielczarek@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b395d1d3585
Remove toolkit/crashreporter/tools/win32. r=gsvelto

Comment 5

3 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.