1392603 - Remove toolkit/crashreporter/tools/win32

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, enhancement)

Description

[(not currently active) Ted Mielczarek]

We have prebuilt dump_syms binaries in toolkit/crashreporter/tools/win32 from the days when we didn't build it as part of the build. There's one per MSVC version, since the APIs it uses are version-specific, but we don't actually support building with the MSVC versions corresponding to the binaries in that directory anymore, so we should just remove them.

Comment 1

[(not currently active) Ted Mielczarek]

The only place that even references this now is unit-symbolstore.py:
https://dxr.mozilla.org/mozilla-central/rev/f0abd25e1f4acced652d180c34b7c9eda638deb1/toolkit/crashreporter/tools/unit-symbolstore.py#463

...but that test is already broken because we don't have a prebuilt binary for MSVC 2015 or 2017.

Comment 2

[(not currently active) Ted Mielczarek]

Attachment: bug 1392603 - Remove toolkit/crashreporter/tools/win32. r?gsvelto

We have prebuilt dump_syms binaries in toolkit/crashreporter/tools/win32 from
the days when we didn't build it as part of the build. There's one per MSVC
version, since the APIs it uses are version-specific, but we don't actually
support building with the MSVC versions corresponding to the binaries in that
directory anymore, so we should just remove them.

The only code change necessary here is changing the functional test to skip
running the test if a dump_syms binary isn't available.

MozReview-Commit-ID: IBuJZMVfv7C

Comment 3

[(not currently active) Ted Mielczarek]

Apparently I have had this patch sitting in my local repo for a while.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b395d1d3585
Remove toolkit/crashreporter/tools/win32. r=gsvelto

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5b395d1d3585