1392631 - Flexible spacers can end up in the overflow panel on narrow windows

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[:Gijs (he/him)]

STR:

1. on OS X, 15" retina mbp, open with a new profile
2. resize the browser window from right to left so it's < 1/3 of the screen and most stuff ends up in the overflow panel
3. open the overflow panel

ER:
all the items fill up the width of the panel

AR:
they do not. This is especially noticeable with the search bar, which flexes, but is generally visible. We should just be hiding the spacers.


I could have sworn this used to work and I don't really understand why it would have broken. Haven't looked if it's a regression though, so maybe my brain is just messing with me.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1392631 - hide flexible spacers in the dynamic portion of the menu panel,

Review commit: https://reviewboard.mozilla.org/r/171578/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171578/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8900205 [details]
Bug 1392631 - hide flexible spacers in the dynamic portion of the menu panel,

https://reviewboard.mozilla.org/r/171578/#review177052

::: browser/base/content/browser.css:776
(Diff revision 1)
> +#widget-overflow-list > toolbarspring {
> +  display: none;
> +}

I just checked on my normal profile and the toolbarspring doesn't have overflowable=false. That would have prevented this, right?

I think that would be the better fix. This seems more like a bandaid.

Comment 3

[:Gijs (he/him)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)
> Comment on attachment 8900205 [details]
> Bug 1392631 - hide flexible spacers in the dynamic portion of the menu panel,
> 
> https://reviewboard.mozilla.org/r/171578/#review177052
> 
> ::: browser/base/content/browser.css:776
> (Diff revision 1)
> > +#widget-overflow-list > toolbarspring {
> > +  display: none;
> > +}
> 
> I just checked on my normal profile and the toolbarspring doesn't have
> overflowable=false. That would have prevented this, right?
> 
> I think that would be the better fix. This seems more like a bandaid.

Then they stay in the navbar on narrow windows, taking up space. I don't think we want that...

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8900205 [details]
Bug 1392631 - hide flexible spacers in the dynamic portion of the menu panel,

https://reviewboard.mozilla.org/r/171578/#review177104

Ah yes, I forgot that we no longer let them go to width:0.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91945d7c9e4b
hide flexible spacers in the dynamic portion of the menu panel, r=jaws

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/91945d7c9e4b

Comment 7

[u554753]

Verified on Mac OS X 10.13 using Nightly 58.0a1 (64-bit) as of this date. Was this an OS X-specific issue or do the Windows and Linux builds need to be looked at as well?

NI Jared since he worked on this bug and Gijs is away.

Comment 8

[:Gijs (he/him)]

(In reply to Grover Wimberly IV [:Grover-QA] from comment #7)
> Was this an OS X-specific issue or do the Windows and Linux builds need to
> be looked at as well?

This wasn't an OS-specific issue (though the fix is generic, too) so it wouldn't hurt to check Linux + Windows.

> NI Jared since he worked on this bug and Gijs is away.

FWIW, still around until the end of tomorrow. :-)

Comment 9

[u554753]

Verified also on Windows 10 64bit and Ubuntu 16.04 64bit using Nightly 58.0a1 (64-bit) as of today's date.

Comment 10

[Emil Ghitta, QA [:emilghitta]]

I have reproduced the issue mentioned in comment 0 using an affected Firefox 57.0a1 build (BuildId:20170822100529).

I have verified that the issue is not reproducible using Firefox 57.0b9 (Build Id:20171016185129) on Windows 10 64bit, macOS 10.11.6 and Ubuntu 16.04 64bit.