Closed
Bug 1392631
Opened 7 years ago
Closed 7 years ago
Flexible spacers can end up in the overflow panel on narrow windows
Categories
(Firefox :: Toolbars and Customization, defect, P1)
Firefox
Toolbars and Customization
Tracking
()
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
(Whiteboard: [reserve-photon-structure])
Attachments
(1 file)
STR: 1. on OS X, 15" retina mbp, open with a new profile 2. resize the browser window from right to left so it's < 1/3 of the screen and most stuff ends up in the overflow panel 3. open the overflow panel ER: all the items fill up the width of the panel AR: they do not. This is especially noticeable with the search bar, which flexes, but is generally visible. We should just be hiding the spacers. I could have sworn this used to work and I don't really understand why it would have broken. Haven't looked if it's a regression though, so maybe my brain is just messing with me.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: qe-verify+
Flags: in-testsuite?
Priority: -- → P1
Whiteboard: [reserve-photon-structure]
Assignee | ||
Updated•7 years ago
|
QA Contact: gwimberly
Updated•7 years ago
|
Iteration: --- → 57.2 - Aug 29
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8900205 [details] Bug 1392631 - hide flexible spacers in the dynamic portion of the menu panel, https://reviewboard.mozilla.org/r/171578/#review177052 ::: browser/base/content/browser.css:776 (Diff revision 1) > +#widget-overflow-list > toolbarspring { > + display: none; > +} I just checked on my normal profile and the toolbarspring doesn't have overflowable=false. That would have prevented this, right? I think that would be the better fix. This seems more like a bandaid.
Attachment #8900205 -
Flags: review?(jaws) → review-
Assignee | ||
Comment 3•7 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2) > Comment on attachment 8900205 [details] > Bug 1392631 - hide flexible spacers in the dynamic portion of the menu panel, > > https://reviewboard.mozilla.org/r/171578/#review177052 > > ::: browser/base/content/browser.css:776 > (Diff revision 1) > > +#widget-overflow-list > toolbarspring { > > + display: none; > > +} > > I just checked on my normal profile and the toolbarspring doesn't have > overflowable=false. That would have prevented this, right? > > I think that would be the better fix. This seems more like a bandaid. Then they stay in the navbar on narrow windows, taking up space. I don't think we want that...
Flags: needinfo?(jaws)
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8900205 [details] Bug 1392631 - hide flexible spacers in the dynamic portion of the menu panel, https://reviewboard.mozilla.org/r/171578/#review177104 Ah yes, I forgot that we no longer let them go to width:0.
Attachment #8900205 -
Flags: review- → review+
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/91945d7c9e4b hide flexible spacers in the dynamic portion of the menu panel, r=jaws
Updated•7 years ago
|
Flags: needinfo?(jaws)
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/91945d7c9e4b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Verified on Mac OS X 10.13 using Nightly 58.0a1 (64-bit) as of this date. Was this an OS X-specific issue or do the Windows and Linux builds need to be looked at as well? NI Jared since he worked on this bug and Gijs is away.
status-firefox58:
--- → verified
Flags: needinfo?(jaws)
Assignee | ||
Comment 8•7 years ago
|
||
(In reply to Grover Wimberly IV [:Grover-QA] from comment #7) > Was this an OS X-specific issue or do the Windows and Linux builds need to > be looked at as well? This wasn't an OS-specific issue (though the fix is generic, too) so it wouldn't hurt to check Linux + Windows. > NI Jared since he worked on this bug and Gijs is away. FWIW, still around until the end of tomorrow. :-)
Flags: needinfo?(jaws)
Verified also on Windows 10 64bit and Ubuntu 16.04 64bit using Nightly 58.0a1 (64-bit) as of today's date.
Comment 10•7 years ago
|
||
I have reproduced the issue mentioned in comment 0 using an affected Firefox 57.0a1 build (BuildId:20170822100529). I have verified that the issue is not reproducible using Firefox 57.0b9 (Build Id:20171016185129) on Windows 10 64bit, macOS 10.11.6 and Ubuntu 16.04 64bit.
You need to log in
before you can comment on or make changes to this bug.
Description
•