1392633 - Bookmark properties dialog has no background or titlebar

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Attachment: bookmark properties missing background

In current 64-bit Nightly on a clean profile on Windows 10:

1. Click menu -> library -> bookmarks
2. Right click on a bookmark and select properties

Properties window shows text edit boxes and labels, but no window background titlebar, or frame

Expected: Dialog appears as a normal Windows dialog, with background and window frame

mozregression:
INFO: Last good revision: ecc3f03e5eaed2a4908b5f1a14759585f9a0b01a
INFO: First bad revision: 3c5b27abffa754649bfcfde71f9516a930316d23
INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ecc3f03e5eaed2a4908b5f1a14759585f9a0b01a&tochange=3c5b27abffa754649bfcfde71f9516a930316d23

This seems to be related, then, to bug 1384504

Comment 1

[:Gijs (he/him)]

Uhhh:


+++ b/browser/themes/windows/places/places.css
@@ -1,18 +1,31 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 /* Sidebars */
+
+:root {
+  background-color: transparent;
+}

Comment 2

[Nihanth Subramanya [:nhnt11]]

(In reply to :Gijs from comment #1)
> Uhhh:
> 
> 
> +++ b/browser/themes/windows/places/places.css
> @@ -1,18 +1,31 @@
>  /* This Source Code Form is subject to the terms of the Mozilla Public
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  /* Sidebars */
> +
> +:root {
> +  background-color: transparent;
> +}

Lol, sorry, I'm on it.

Comment 5

[Gary [:streetwolf52]]

Also the downloads menu.

Comment 6

[Dão Gottwald [::dao]]

Attachment: Bug 1392633 - Stop removing the background in non-sidebar documents using places.css.

Review commit: https://reviewboard.mozilla.org/r/171290/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171290/

Comment 7

[Nihanth Subramanya [:nhnt11]]

Comment on attachment 8899964 [details]
Bug 1392633 - Stop removing the background in non-sidebar documents using places.css.

https://reviewboard.mozilla.org/r/171290/#review176464

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf3a6dfc75c2
Stop removing the background in non-sidebar documents using places.css. r=nhnt11

Comment 12

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/cf3a6dfc75c2

Comment 17

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 57.0a1 (2017-08-24), so I'm marking this bug as VERIFIED. Thanks.

Comment 18

[smartfon.reddit]

The title bar is fixed, but now there is an excessive white space on the right corner of History popup
http://i.imgur.com/hwvr1c9.png

Comment 19

[Alice0775 White]

(In reply to smartfon.reddit from comment #18)
> The title bar is fixed, but now there is an excessive white space on the
> right corner of History popup
> http://i.imgur.com/hwvr1c9.png

this is Bug 1393411