Closed
Bug 1392653
Opened 7 years ago
Closed 7 years ago
Crash in AsyncShutdownTimeout | profile-change-teardown | Legacy Extension Shutdown: screenshots@mozilla.org
Categories
(Firefox :: Screenshots, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | fixed |
firefox57 | --- | fixed |
People
(Reporter: marcia, Assigned: kmag)
Details
(Keywords: crash, regression)
Crash Data
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
aswan
:
review+
lizzard
:
approval-mozilla-beta+
|
Details |
This bug was filed from the Socorro interface and is report bp-88c3ffc7-7fbf-466f-8e13-65bc20170822. ============================================================= Seen while looking at crash stats - new crash in Beta 4 that was not present in previous betas: http://bit.ly/2g2mvGg Crashes seen on trunk as well. Adding :kmag since he worked on Bug 1383489
Flags: needinfo?(kmaglione+bmo)
Comment 1•7 years ago
|
||
Moving to Screenshots component, as this bug seems similar to bug 1380267
Component: WebExtensions: General → Screenshots
Product: Toolkit → Cloud Services
Version: Trunk → unspecified
Assignee | ||
Comment 2•7 years ago
|
||
Hm. I guess the legacy extension shutdown blocker is redundant at this point.
Assignee: nobody → kmaglione+bmo
Flags: needinfo?(kmaglione+bmo)
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8900927 [details] Bug 1392653: Remove redundant LegacyExtensionUtils shutdown blocker. https://reviewboard.mozilla.org/r/172366/#review177772 Cleaning this up seems good but I didn't look at the associated crash report, how did this lead to a crash?
Attachment #8900927 -
Flags: review?(aswan) → review+
Assignee | ||
Comment 5•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3aa4bc482372340ca890b1b0b5fd0937d21b725d Bug 1392653: Remove redundant LegacyExtensionUtils shutdown blocker. r=aswan
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3aa4bc482372
Comment 7•7 years ago
|
||
Please request Beta approval on this when you get a chance.
status-firefox55:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Flags: needinfo?(kmaglione+bmo)
Assignee | ||
Comment 8•7 years ago
|
||
Comment on attachment 8900927 [details] Bug 1392653: Remove redundant LegacyExtensionUtils shutdown blocker. Approval Request Comment [Feature/Bug causing the regression]: N/A [User impact if declined]: This causes shutdown hangs in certain corner cases when hybrid add-ons (such as Screenshots) are running, usually as a result of a content process hang. [Is this code covered by automated tests?]: Yes. [Has the fix been verified in Nightly?]: N/A [Needs manual test from QE? If yes, steps to reproduce]: No. This is something that only happens in corner cases that are hard to reproduce. [List of other uplifts needed for the feature/fix]: None. [Is the change risky?]: No. [Why is the change risky/not risky?]: This simply removes a redundant shutdown blocker, which prevents the timeout in the existing shutdown blocker from taking effect for hybrid extensions. [String changes made/needed]: None
Flags: needinfo?(kmaglione+bmo)
Attachment #8900927 -
Flags: approval-mozilla-beta?
Comment 9•7 years ago
|
||
Comment on attachment 8900927 [details] Bug 1392653: Remove redundant LegacyExtensionUtils shutdown blocker. Fix for some shutdown hangs, let's uplift for beta 8.
Attachment #8900927 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 10•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/c46525d6bf12
Comment 11•7 years ago
|
||
(In reply to Kris Maglione [:kmag] from comment #8) > [Is this code covered by automated tests?]: Yes. > [Has the fix been verified in Nightly?]: N/A > [Needs manual test from QE? If yes, steps to reproduce]: No. This is > something that only happens in corner cases that are hard to reproduce. Setting qe-verify- based on Kris's assessment on manual testing needs and the fact that this fix has automated coverage.
Flags: qe-verify-
Updated•7 years ago
|
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•