Closed
Bug 1392681
Opened 8 years ago
Closed 8 years ago
Move IStream creation out of ProxyStream into its own utility function
Categories
(Core :: Disability Access APIs, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: bugzilla, Assigned: bugzilla)
References
Details
Attachments
(1 file, 1 obsolete file)
|
16.85 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
I'm going to need this in some other code.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8899915 -
Flags: review?(jmathies)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Attachment #8899915 -
Attachment is obsolete: true
Attachment #8899915 -
Flags: review?(jmathies)
Attachment #8899941 -
Flags: review?(jmathies)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8899941 [details] [diff] [review]
Add CreateStream and CopySerializedProxy to mscom/Utils.h (r2)
Review of attachment 8899941 [details] [diff] [review]:
-----------------------------------------------------------------
::: ipc/mscom/Utils.cpp
@@ +114,5 @@
> + HRESULT hr;
> + RefPtr<IStream> stream;
> +
> + if (IsWin8OrLater()) {
> + // This function is not safe for us to use until Windows 8
this comment should also address why it's not safe.
Attachment #8899941 -
Flags: review?(jmathies) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ca1a9de85b58c032fb15b2ea8ecadedacdcdfbe
Bug 1392681: Move IStream creation out of mscom::ProxyStream into its own utility functions; r=jimm
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•