Closed Bug 1392687 Opened 5 years ago Closed 5 years ago

"Show more bookmarks" icon on the Bookmarks Toolbar should be mirrored for RTL builds

Categories

(Firefox :: Theme, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 57
Iteration:
57.2 - Aug 29
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- verified

People

(Reporter: itiel_yn8, Assigned: dao)

References

Details

(Keywords: regression, Whiteboard: [reserve-photon-visual])

Attachments

(2 files)

When the Bookmarks Toolbar is overflowing, the "Show more bookmarks" icon should be mirrored in RTL builds.

See screenshot attached for how it currently looks.
Is this a regression? I would expect this used to work on stable...
Flags: needinfo?(itiel_yn8)
(In reply to :Gijs from comment #1)
> Is this a regression? I would expect this used to work on stable...

Yep.

2017-08-23T19:52:42: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=500a01cf896dbb9883cb85f162552e20b8facfc0&full=1
2017-08-23T19:52:43: DEBUG : Found commit message:
Bug 1377184 - Consistently use the custom toolbar button styling in all browser toolbars. r=johannh

MozReview-Commit-ID: DvMorv7HhDu

2017-08-23T19:52:43: INFO : The bisection is done.
2017-08-23T19:52:43: INFO : Stopped


The previous button was much smaller, and (in RTL builds) pointing left.
Flags: needinfo?(itiel_yn8)
Blocks: 1377184
Keywords: regression
Whiteboard: [photon-visual][triage]
Assignee: nobody → dao+bmo
Priority: -- → P1
Whiteboard: [photon-visual][triage] → [reserve-photon-visual]
Status: NEW → ASSIGNED
Iteration: --- → 57.2 - Aug 29
Flags: qe-verify?
Comment on attachment 8900370 [details]
Bug 1392687 - Mirror the bookmarks toolbar chevron in RTL builds.

https://reviewboard.mozilla.org/r/171732/#review177376
Comment on attachment 8900370 [details]
Bug 1392687 - Mirror the bookmarks toolbar chevron in RTL builds.

https://reviewboard.mozilla.org/r/171732/#review177378
Attachment #8900370 - Flags: review?(nhnt11) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/85f37d789b74
Mirror the bookmarks toolbar chevron in RTL builds. r=nhnt11
Flags: qe-verify? → qe-verify+
QA Contact: ovidiu.boca
https://hg.mozilla.org/mozilla-central/rev/85f37d789b74
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
I verified this on Mac OS X 10.10 and Windows 10 with FF Nightly 57.0a1(2017-08-24) with the Arabic build and I can confirm the fix.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.