Closed
Bug 1392722
Opened 7 years ago
Closed 5 years ago
DOMMatrixReadOnly.rotateFromVector() returns wrong matrix if x or y params are zero
Categories
(Core :: DOM: Core & HTML, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla69
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: paul.lebeau, Assigned: saschanaz)
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:54.0) Gecko/20100101 Firefox/54.0 Build ID: 20170628075643 Steps to reproduce: Try the following test: https://jsfiddle.net/uezpwx14/2/ let m = new DOMMatrix(); console.log("Expected: " + m.rotate(90)); console.log("Actual: " + m.rotateFromVector(0, 1)); Actual results: rotateFromVector(0, 1) returns an unchanged matrix. Expected results: rotateFromVector(0, 1) should give the same result as rotate(90) rotateFromVector() seems to return the correct results if neither of the x and y parameters are zero. But if either are 0, an unchanged matrix is returned. This behaviour is expected if BOTH parameters are zero, so I am guessing that there is a || in that test where there should be an && :)
Updated•7 years ago
|
Component: Untriaged → DOM
Product: Firefox → Core
Comment 1•7 years ago
|
||
Looks like out testsuite expects it to throw: https://dxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/general/test_DOMMatrix.html The equivalent SVG 1.1 method throws: https://www.w3.org/TR/SVG/coords.html#__svg__SVGMatrix__rotateFromVector
Updated•7 years ago
|
Priority: -- → P3
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
Assignee | ||
Comment 2•5 years ago
|
||
Aligns to the spec. Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7c12c831fb8a6ce0d5ec6b31fcf1f708464deaf
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → saschanaz
Keywords: checkin-needed
Updated•5 years ago
|
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment 3•5 years ago
|
||
This patch could not be landed due to uncomitted changes. Removing the checkin-needed tag.
Flags: needinfo?(saschanaz)
Keywords: checkin-needed
Assignee | ||
Updated•5 years ago
|
Flags: needinfo?(saschanaz)
Keywords: checkin-needed
Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cc6fbf8afb48
Allow zero in rotateFromVector r=bzbarsky
Keywords: checkin-needed
Comment 5•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17703 for changes under testing/web-platform/tests
Upstream PR merged
You need to log in
before you can comment on or make changes to this bug.
Description
•