1392752 - Add Tracking Protection status to core ping

Status: RESOLVED INACTIVE

(Firefox for iOS :: Telemetry, enhancement, P3)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Add Tracking Protection status to core ping so that we know the two settings: on-state (off, private-only, always) and level (basic, strict).

Comment 1

[:garvan]

Attachment: Pull request

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8906083 [details] [review]
Pull request

Looks good.

Comment 3

[:garvan]

landed master and v9.x

Comment 4

[Frank Bertsch [:frank]]

Hi Rebecca, requesting data review. This is Category 2 Interaction Data, as it is just tracking protection settings.

Reference for others: https://wiki.mozilla.org/Firefox/Data_Collection#Data_Collection_Categories

Comment 5

[:garvan]

Added https://bugzilla.mozilla.org/show_bug.cgi?id=1398924, to change all the settings to use a single JSON dict.

Comment 6

[[e-mail]]

:Frank, can either you or :st3fan amend this bug with a file containing your answers to these questions:
https://docs.google.com/document/d/1SSn5w8DfCSkHWJS8DNTd7ya82diWRxaDUFM5aL4UDDo/edit

Comment 7

[:garvan]

If the schema is *not* updated, will this patch break telemetry ping? That is, will a schema mismatch cause all the ping data to be dropped (vs. just having the Tracking Protection settings telemetry dropped until the schema is updated).

Am concerned that this simple change is having greater side effects than intended.
Is it too late to back it out for 9.0?
:st3fan will ping you on slack about it

Comment 8

[:garvan]

I'd like to back this out for 9.0 and we can deal with the settings-as-a-whole properly for 9.1.

Comment 9

[Frank Bertsch [:frank]]

(In reply to Rebecca Weiss from comment #6)
> :Frank, can either you or :st3fan amend this bug with a file containing your
> answers to these questions:
> https://docs.google.com/document/d/
> 1SSn5w8DfCSkHWJS8DNTd7ya82diWRxaDUFM5aL4UDDo/edit

Stefan, can you take care of this?

Comment 10

[:garvan]

Re-opening, there is a better way to add this to core ping:
https://bugzilla.mozilla.org/show_bug.cgi?id=1398924

Will fix for 9.1. 

Backing out this patch.

Comment 11

[:garvan]

Reverted from 9.0:
commit cc002af4a9c043597d294f8a17a391672b86485f (HEAD -> v9.x, origin/v9.x)
Date:   Wed Sep 13 10:27:13 2017 -0400
    Revert "Bug 1392752: tracking protection status added to core ping (#3147)"
    This reverts commit 7a52d8c2a588e6c99131c86d8c8cb0d9f75cc44e.