1392757 - Swipe left/right stopped working in Android

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

This has to do with with AccessibilityNodeInfo.performAction now receiving a truthy 'arguments' argument[1].

I could investigate further what the specific changes are for, but what is clear and needs to be fixed is our movement rule resolution.


1.https://dxr.mozilla.org/mozilla-central/source/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoAccessibility.java#315

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Be more resilient for data values we get in Android object navigation. r?yzen

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8899967 [details] [diff] [review]
Be more resilient for data values we get in Android object navigation. r?yzen

Review of attachment 8899967 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8aa84d9344c
Be more resilient for data values we get in Android object navigation. r=yzen

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a8aa84d9344c

Comment 5

[Eitan Isaacson [:eeejay]]

This may be an Android platform regression, I tested this on Nougat/Oreo, but earlier versions may still work.

Comment 6

[Eitan Isaacson [:eeejay]]

Comment on attachment 8899967 [details] [diff] [review]
Be more resilient for data values we get in Android object navigation. r?yzen

Approval Request Comment
[Feature/Bug causing the regression]: An Android platform change
[User impact if declined]: Screen reader is not usable in content.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: Start TalkBack and load any page in Firefox. Swipe left. The cursor should advance to the next item.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No. 
[Why is the change risky/not risky?]: This is a change in our accessibility frontend code that does not affect other users who didn't already have a broken experience.
[String changes made/needed]: None.

Comment 7

[Gerry Chang [:gchang]]

Comment on attachment 8899967 [details] [diff] [review]
Be more resilient for data values we get in Android object navigation. r?yzen

Fix an accessibility issue. Beta56+.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e2a6a68b8918

Comment 9

[Julien Cristau [:jcristau]]

We're two weeks away from 56 release and there are no plans for 55.0.4 at this time.