Closed
Bug 1392757
Opened 7 years ago
Closed 7 years ago
Swipe left/right stopped working in Android
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla57
People
(Reporter: eeejay, Assigned: eeejay)
Details
Attachments
(1 file)
1.29 KB,
patch
|
yzen
:
review+
gchang
:
approval-mozilla-beta+
jcristau
:
approval-mozilla-release-
|
Details | Diff | Splinter Review |
This has to do with with AccessibilityNodeInfo.performAction now receiving a truthy 'arguments' argument[1]. I could investigate further what the specific changes are for, but what is clear and needs to be fixed is our movement rule resolution. 1.https://dxr.mozilla.org/mozilla-central/source/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoAccessibility.java#315
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8899967 -
Flags: review?(yzenevich)
Comment 2•7 years ago
|
||
Comment on attachment 8899967 [details] [diff] [review] Be more resilient for data values we get in Android object navigation. r?yzen Review of attachment 8899967 [details] [diff] [review]: ----------------------------------------------------------------- thanks!
Attachment #8899967 -
Flags: review?(yzenevich) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a8aa84d9344c Be more resilient for data values we get in Android object navigation. r=yzen
Keywords: checkin-needed
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a8aa84d9344c
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Assignee | ||
Updated•7 years ago
|
status-firefox55:
--- → affected
status-firefox56:
--- → affected
Assignee | ||
Comment 5•7 years ago
|
||
This may be an Android platform regression, I tested this on Nougat/Oreo, but earlier versions may still work.
Assignee | ||
Comment 6•7 years ago
|
||
Comment on attachment 8899967 [details] [diff] [review] Be more resilient for data values we get in Android object navigation. r?yzen Approval Request Comment [Feature/Bug causing the regression]: An Android platform change [User impact if declined]: Screen reader is not usable in content. [Is this code covered by automated tests?]: No. [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: Start TalkBack and load any page in Firefox. Swipe left. The cursor should advance to the next item. [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No. [Why is the change risky/not risky?]: This is a change in our accessibility frontend code that does not affect other users who didn't already have a broken experience. [String changes made/needed]: None.
Attachment #8899967 -
Flags: approval-mozilla-release?
Attachment #8899967 -
Flags: approval-mozilla-beta?
Comment 7•7 years ago
|
||
Comment on attachment 8899967 [details] [diff] [review] Be more resilient for data values we get in Android object navigation. r?yzen Fix an accessibility issue. Beta56+.
Attachment #8899967 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 8•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/e2a6a68b8918
Comment 9•7 years ago
|
||
We're two weeks away from 56 release and there are no plans for 55.0.4 at this time.
Updated•7 years ago
|
Attachment #8899967 -
Flags: approval-mozilla-release? → approval-mozilla-release-
You need to log in
before you can comment on or make changes to this bug.
Description
•