Closed Bug 1392764 Opened 2 years ago Closed 2 years ago

Port the FX changes for the in-content prefs to TB

Categories

(Thunderbird :: Theme, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 57.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files, 1 obsolete file)

FX had some changes for the in-content prefs and other in-content pages to match the Photon visual specs.

Bug 1357306 - [meta] Preferences visual refresh.
Bug 1377174 - Tweak margin to match the spec.
Bug 1386514 - Support RWD for about:preferences to match Photon visual spec.
Bug 1388997 - Add hover effects for menu items on preference page.
Attached patch prefs.patch (obsolete) — Splinter Review
The most visible change are the categories on the left side. I use now new icons for "General", "Composition", "Security" and "Attachments". General and Security are from FX, the other two are from Monterail theme.

I separated the icons into single files like FX also did. It seems this is faster than a single file with all icons in it.

I also followed the font size changes of FX prefs. The colors are taken directly from toolkit.

To test the patch try to resize the window and look how the categories shrink and grow and correlate it to the Add-ons Manager. But the margins aren't the same on AM like on FX prefs.

We can't completely follow the FX prefs as we still use the same prefs for the windowed prefs.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8899972 - Flags: review?(jorgk)
Comment on attachment 8899972 [details] [diff] [review]
prefs.patch

Sorry, but I think this looks pretty terrible.

Can't we make the headings a little smaller or have more space?

Can't we have at least a line separating the menu on the left from the content on the right? Also for add-ons? Or a mild grey?

The previous in-content prefs looked elegant, this looks like version 0.0.1 of a website where all the content is there any no one has thought about the formatting yet.
Attached image Suggestion
That's with
caption > label {
  font-size: 1.3rem;
and #ebebeb.
I'm also not a fan of this no separation between category area and content. For our prefs your proposal is no problem but I need to look how I can override the toolkit pages.
Attached patch prefs.patchSplinter Review
Luckily we had already a overlay for the legacy label in Add-ons manager. I added a new CSS file in skin to not force our color to 3rd party themes.
Attachment #8899972 - Attachment is obsolete: true
Attachment #8899972 - Flags: review?(jorgk)
Attachment #8900384 - Flags: review?(jorgk)
Comment on attachment 8900384 [details] [diff] [review]
prefs.patch

Fantastic!
Attachment #8900384 - Flags: review?(jorgk) → review+
Thanks.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e521a32d97d2
Port the FX changes for the in-content prefs to TB. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 57.0
You need to log in before you can comment on or make changes to this bug.