Closed Bug 1392795 Opened 3 years ago Closed 3 years ago

Yamllint config files not picked up in subdirectories

Categories

(Firefox Build System :: Lint and Formatting, enhancement)

enhancement
Not set
normal

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: ahal, Assigned: ahal)

Details

Attachments

(1 file)

I've noticed some inconsistencies with the yaml linter. If you pass a directory, things seem to pass, but passing an individual files under that directory fails. E.g:
./mach lint -l yaml taskcluster  # passes
./mach lint -l yaml taskcluster/ci/source-test/mozlint.yml  # fails

This could be a bug in mozlint's path filtering.
Oh, this is happening because of that .yamllint hack. When running ./mach lint -l yaml taskcluster/ci, the .yamllint under /taskcluster doesn't get picked up.

This causes the push/commit hooks to fail because ./mach lint --outgoing/--workdir will pass in the absolute file paths of touched files.
Summary: Errors not being picked up by yaml linter → Yamllint config files not picked up in subdirectories
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Hey dustin, I know you aren't familiar with this code, but Callek is PTO for another couple weeks and you helped review bug 1387862. Let me know if you need some more context.
Comment on attachment 8900470 [details]
Bug 1392795 - [yamllint] Group paths to lint by their closest config and run each config group separately,

https://reviewboard.mozilla.org/r/171828/#review177590

I think I get it, and it looks good :)
Attachment #8900470 - Flags: review?(dustin) → review+
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f384a3acd016
[yamllint] Group paths to lint by their closest config and run each config group separately, r=dustin
https://hg.mozilla.org/mozilla-central/rev/f384a3acd016
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Product: Testing → Firefox Build System
You need to log in before you can comment on or make changes to this bug.