Yamllint config files not picked up in subdirectories

RESOLVED FIXED in Firefox 57

Status

enhancement
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: ahal, Assigned: ahal)

Tracking

unspecified
mozilla57

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
I've noticed some inconsistencies with the yaml linter. If you pass a directory, things seem to pass, but passing an individual files under that directory fails. E.g:
./mach lint -l yaml taskcluster  # passes
./mach lint -l yaml taskcluster/ci/source-test/mozlint.yml  # fails

This could be a bug in mozlint's path filtering.
Assignee

Comment 1

2 years ago
Oh, this is happening because of that .yamllint hack. When running ./mach lint -l yaml taskcluster/ci, the .yamllint under /taskcluster doesn't get picked up.

This causes the push/commit hooks to fail because ./mach lint --outgoing/--workdir will pass in the absolute file paths of touched files.
Assignee

Updated

2 years ago
Summary: Errors not being picked up by yaml linter → Yamllint config files not picked up in subdirectories
Assignee

Updated

2 years ago
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Assignee

Comment 3

2 years ago
Hey dustin, I know you aren't familiar with this code, but Callek is PTO for another couple weeks and you helped review bug 1387862. Let me know if you need some more context.

Comment 4

2 years ago
mozreview-review
Comment on attachment 8900470 [details]
Bug 1392795 - [yamllint] Group paths to lint by their closest config and run each config group separately,

https://reviewboard.mozilla.org/r/171828/#review177590

I think I get it, and it looks good :)
Attachment #8900470 - Flags: review?(dustin) → review+

Comment 5

2 years ago
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f384a3acd016
[yamllint] Group paths to lint by their closest config and run each config group separately, r=dustin

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f384a3acd016
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57

Updated

Last year
Product: Testing → Firefox Build System
You need to log in before you can comment on or make changes to this bug.